components/password_manager/core/browser/password_manager_client.h - Issue 707173004: Refactor Autofill for out of process iframes (OOPIF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_manager.h ('K') | « components/password_manager/core/browser/password_manager.cc ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_client.h

diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h

index c2ffb4a1dbdc5052a75a2c456d8a57ef08606ae7..3e107522bd77411a1182dbd5ff13117af8a75296 100644

--- a/components/password_manager/core/browser/password_manager_client.h

+++ b/components/password_manager/core/browser/password_manager_client.h

@@ -89,7 +89,9 @@ class PasswordManagerClient {

// Returns the PasswordStore associated with this instance.

virtual PasswordStore* GetPasswordStore() = 0;

+ // DEPRECATED

// Returns the PasswordManagerDriver instance associated with this instance.

+ // TODO(estade): get rid of this.

vabr (Chromium) 2014/11/10 14:34:40 nit: Please also specify what to use instead, and

Evan Stade 2014/11/14 23:25:50 got rid of it

virtual PasswordManagerDriver* GetDriver() = 0;

// Returns the probability that the experiment identified by |experiment_name|