Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: android_webview/native/aw_autofill_client.cc

Issue 707173004: Refactor Autofill for out of process iframes (OOPIF). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix merge fallout, android_webview Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « android_webview/native/aw_autofill_client.h ('k') | android_webview/native/aw_contents.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_autofill_client.h" 5 #include "android_webview/native/aw_autofill_client.h"
6 6
7 #include "android_webview/browser/aw_browser_context.h" 7 #include "android_webview/browser/aw_browser_context.h"
8 #include "android_webview/browser/aw_content_browser_client.h" 8 #include "android_webview/browser/aw_content_browser_client.h"
9 #include "android_webview/browser/aw_form_database_service.h" 9 #include "android_webview/browser/aw_form_database_service.h"
10 #include "android_webview/browser/aw_pref_store.h" 10 #include "android_webview/browser/aw_pref_store.h"
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 return; 151 return;
152 delegate_.reset(); 152 delegate_.reset();
153 Java_AwAutofillClient_hideAutofillPopup(env, obj.obj()); 153 Java_AwAutofillClient_hideAutofillPopup(env, obj.obj());
154 } 154 }
155 155
156 bool AwAutofillClient::IsAutocompleteEnabled() { 156 bool AwAutofillClient::IsAutocompleteEnabled() {
157 return GetSaveFormData(); 157 return GetSaveFormData();
158 } 158 }
159 159
160 void AwAutofillClient::DetectAccountCreationForms( 160 void AwAutofillClient::DetectAccountCreationForms(
161 content::RenderFrameHost* rfh,
161 const std::vector<autofill::FormStructure*>& forms) { 162 const std::vector<autofill::FormStructure*>& forms) {
sgurun-gerrit only 2014/12/02 02:03:50 himm, it seems we need a NOTIMPLEMENTED() here. We
Evan Stade 2014/12/02 02:27:59 Done.
162 } 163 }
163 164
164 void AwAutofillClient::DidFillOrPreviewField( 165 void AwAutofillClient::DidFillOrPreviewField(
165 const base::string16& autofilled_value, 166 const base::string16& autofilled_value,
166 const base::string16& profile_full_name) { 167 const base::string16& profile_full_name) {
167 } 168 }
168 169
170 void AwAutofillClient::OnFirstUserGestureObserved() {
sgurun-gerrit only 2014/12/02 02:03:50 Please add a NOTIMPLEMENTED() here.
Evan Stade 2014/12/02 02:27:59 Done.
171 }
172
169 void AwAutofillClient::SuggestionSelected(JNIEnv* env, 173 void AwAutofillClient::SuggestionSelected(JNIEnv* env,
170 jobject object, 174 jobject object,
171 jint position) { 175 jint position) {
172 if (delegate_) 176 if (delegate_)
173 delegate_->DidAcceptSuggestion(values_[position], identifiers_[position]); 177 delegate_->DidAcceptSuggestion(values_[position], identifiers_[position]);
174 } 178 }
175 179
176 void AwAutofillClient::HideRequestAutocompleteDialog() { 180 void AwAutofillClient::HideRequestAutocompleteDialog() {
177 NOTIMPLEMENTED(); 181 NOTIMPLEMENTED();
178 } 182 }
(...skipping 13 matching lines...) Expand all
192 const GURL& source_url, 196 const GURL& source_url,
193 const ResultCallback& callback) { 197 const ResultCallback& callback) {
194 NOTIMPLEMENTED(); 198 NOTIMPLEMENTED();
195 } 199 }
196 200
197 bool RegisterAwAutofillClient(JNIEnv* env) { 201 bool RegisterAwAutofillClient(JNIEnv* env) {
198 return RegisterNativesImpl(env); 202 return RegisterNativesImpl(env);
199 } 203 }
200 204
201 } // namespace android_webview 205 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/native/aw_autofill_client.h ('k') | android_webview/native/aw_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698