Refactor Autofill for out of process iframes (OOPIF).

components/password_manager/core/browser/password_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 31 matching lines @@
 // database through the PasswordStore. The PasswordManager is a LoginModel
 // for purposes of supporting HTTP authentication dialogs.
 class PasswordManager : public LoginModel {
  public:
   static const char kOtherPossibleUsernamesExperiment[];
 
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
 #if defined(OS_WIN)
   static void RegisterLocalPrefs(PrefRegistrySimple* registry);
 #endif
-  explicit PasswordManager(PasswordManagerClient* client);
+  PasswordManager(PasswordManagerClient* client, PasswordManagerDriver* driver);

[vabr (Chromium), 2014/11/13 14:01:33]

Oh, and actually, having one PasswordManager per frame rather than page is a big
change. Currently it aggregates password form information from all frames, so
isolating that would certainly change its behaviour.

At a first shot it looks to me like there should be exactly one PasswordManager
for one PasswordManagerClient, and it should get access to the driver factory
instead of to particular drivers.

But I'll need to think about this more. Will update this CL if I find reason
against having managers to clients 1:1.

   ~PasswordManager() override;
 
   typedef base::Callback<void(const autofill::PasswordForm&)>
       PasswordSubmittedCallback;
 
   // There is no corresponding remove function as currently all of the
   // owners of these callbacks have sufficient lifetimes so that the callbacks
   // should always be valid when called.
   void AddSubmissionCallback(const PasswordSubmittedCallback& callback);
 
@@ skipping 137 matching lines @@
   // the recorded forms matches the login form from the previous page
   // (to see if the login was a failure), and clears the vector.
   std::vector<autofill::PasswordForm> all_visible_forms_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordManager);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_