Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2213)

Unified Diff: content/shell/renderer/test_runner/web_test_proxy.cc

Issue 707173003: Disable load completion hacks flag, remove usages of the flag in chromium (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/test_runner/web_test_proxy.cc
diff --git a/content/shell/renderer/test_runner/web_test_proxy.cc b/content/shell/renderer/test_runner/web_test_proxy.cc
index e39fd86a9ab04881f15814b467e35f6bdf64ddd5..a04adbdd5bac49ac10ea39abf21b0e72f6e62896 100644
--- a/content/shell/renderer/test_runner/web_test_proxy.cc
+++ b/content/shell/renderer/test_runner/web_test_proxy.cc
@@ -1214,9 +1214,7 @@ void WebTestProxyBase::DidFinishResourceLoad(blink::WebLocalFrame* frame,
delegate_->PrintMessage(" - didFinishLoading\n");
}
resource_identifier_map_.erase(identifier);
-#if !defined(ENABLE_LOAD_COMPLETION_HACKS)
CheckDone(frame, ResourceLoadCompleted);
-#endif
}
void WebTestProxyBase::DidAddMessageToConsole(
@@ -1265,17 +1263,9 @@ void WebTestProxyBase::CheckDone(blink::WebLocalFrame* frame,
CheckDoneReason reason) {
if (frame != test_interfaces_->GetTestRunner()->topLoadingFrame())
return;
-
-#if !defined(ENABLE_LOAD_COMPLETION_HACKS)
- // Quirk for MHTML prematurely completing on resource load completion.
Nate Chapin 2014/12/11 18:21:13 I found the bugs that required this quirk, the las
- std::string mime_type = frame->dataSource()->response().mimeType().utf8();
- if (reason == ResourceLoadCompleted && mime_type == "multipart/related")
- return;
-
if (reason != MainResourceLoadFailed &&
(frame->isResourceLoadInProgress() || frame->isLoading()))
return;
-#endif
test_interfaces_->GetTestRunner()->setTopLoadingFrame(frame, true);
}
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698