Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 707173003: Disable load completion hacks flag, remove usages of the flag in chromium (Closed)

Created:
6 years, 1 month ago by Nate Chapin
Modified:
6 years ago
Reviewers:
Nico, nasko
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable load completion hacks flag, remove usages of the flag in chromium The flag can be removed once the remaining references in blink are removed. BUG=426520 Committed: https://crrev.com/a914d782e17c9bfdc49428043dc41d0eaa6ca645 Cr-Commit-Position: refs/heads/master@{#307992}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M build/common.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 2 3 2 chunks +0 lines, -10 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
Nate Chapin
nasko: PTAL at the content/shell/ changes. https://codereview.chromium.org/707173003/diff/60001/content/shell/renderer/test_runner/web_test_proxy.cc File content/shell/renderer/test_runner/web_test_proxy.cc (left): https://codereview.chromium.org/707173003/diff/60001/content/shell/renderer/test_runner/web_test_proxy.cc#oldcode1270 content/shell/renderer/test_runner/web_test_proxy.cc:1270: // Quirk for ...
6 years ago (2014-12-11 18:21:13 UTC) #2
Nate Chapin
thakis, would you mind rubber-stamping this flag change in build/common.gypi? It's a temporary flag that ...
6 years ago (2014-12-11 18:22:22 UTC) #4
nasko
content/shell LGTM
6 years ago (2014-12-11 18:24:50 UTC) #5
Nico
build/ lgtm
6 years ago (2014-12-11 18:35:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707173003/60001
6 years ago (2014-12-11 18:37:39 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-11 23:11:16 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-11 23:11:59 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a914d782e17c9bfdc49428043dc41d0eaa6ca645
Cr-Commit-Position: refs/heads/master@{#307992}

Powered by Google App Engine
This is Rietveld 408576698