Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: media/cast/video_sender/video_sender.cc

Issue 70713002: Cast: Restructure RTCP interface to better fit our usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/cast/rtcp/rtcp_sender.cc ('K') | « media/cast/video_sender/video_sender.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/video_sender/video_sender.cc
diff --git a/media/cast/video_sender/video_sender.cc b/media/cast/video_sender/video_sender.cc
index 966fe9330406fbc5e4d0ebea71a5c1cd8bf37825..40400b15dc49a8e966a2f68ea2a3950149442d1f 100644
--- a/media/cast/video_sender/video_sender.cc
+++ b/media/cast/video_sender/video_sender.cc
@@ -53,8 +53,7 @@ VideoSender::VideoSender(
const VideoSenderConfig& video_config,
VideoEncoderController* const video_encoder_controller,
PacedPacketSender* const paced_packet_sender)
- : incoming_feedback_ssrc_(video_config.incoming_feedback_ssrc),
- rtp_max_delay_(
+ : rtp_max_delay_(
base::TimeDelta::FromMilliseconds(video_config.rtp_max_delay_ms)),
max_frame_rate_(video_config.max_frame_rate),
cast_environment_(cast_environment),
@@ -96,11 +95,9 @@ VideoSender::VideoSender(
NULL,
video_config.rtcp_mode,
base::TimeDelta::FromMilliseconds(video_config.rtcp_interval),
- true,
video_config.sender_ssrc,
+ video_config.incoming_feedback_ssrc,
video_config.rtcp_c_name));
-
- rtcp_->SetRemoteSSRC(video_config.incoming_feedback_ssrc);
ScheduleNextRtcpReport();
ScheduleNextResendCheck();
ScheduleNextSkippedFramesCheck();
@@ -170,7 +167,7 @@ void VideoSender::ScheduleNextRtcpReport() {
}
void VideoSender::SendRtcpReport() {
- rtcp_->SendRtcpReport(incoming_feedback_ssrc_);
+ rtcp_->SendRtcpFromRtpSender(NULL); // TODO(pwestin): add logging.
ScheduleNextRtcpReport();
}
« media/cast/rtcp/rtcp_sender.cc ('K') | « media/cast/video_sender/video_sender.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698