Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: media/cast/rtcp/rtcp_sender.h

Issue 70713002: Cast: Restructure RTCP interface to better fit our usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/rtcp/rtcp_sender.h
diff --git a/media/cast/rtcp/rtcp_sender.h b/media/cast/rtcp/rtcp_sender.h
index 7dbbc0f95b514bfce8d875669c2a5be0333dba92..de97d38b4c7ab2255597c1e30b5c1959e24bc552 100644
--- a/media/cast/rtcp/rtcp_sender.h
+++ b/media/cast/rtcp/rtcp_sender.h
@@ -24,13 +24,16 @@ class RtcpSender {
virtual ~RtcpSender();
- void SendRtcp(uint32 packet_type_flags,
- const RtcpSenderInfo* sender_info,
- const RtcpReportBlock* report_block,
- uint32 pli_remote_ssrc,
- const RtcpDlrrReportBlock* dlrr,
- const RtcpReceiverReferenceTimeReport* rrtr,
- const RtcpCastMessage* cast_message);
+ void SendRtcpFromRtpSender(uint32 packet_type_flags,
+ const RtcpSenderInfo* sender_info,
+ const RtcpDlrrReportBlock* dlrr,
+ const RtcpSenderLogMessage* sender_log);
+
+ void SendRtcpFromRtpReceiver(uint32 packet_type_flags,
+ const RtcpReportBlock* report_block,
+ const RtcpReceiverReferenceTimeReport* rrtr,
+ const RtcpCastMessage* cast_message,
+ const RtcpReceiverLogMessage* receiver_log);
enum RtcpPacketType {
kRtcpSr = 0x0002,
@@ -45,6 +48,8 @@ class RtcpSender {
kRtcpRpsi = 0x8000,
kRtcpRemb = 0x10000,
kRtcpCast = 0x20000,
+ kRtcpSenderLog = 0x40000,
+ kRtcpReceiverLog = 0x80000,
};
private:
@@ -83,6 +88,12 @@ class RtcpSender {
void BuildCast(const RtcpCastMessage* cast_message,
std::vector<uint8>* packet) const;
+ void BuildSenderLog(const RtcpSenderLogMessage* sender_log_message,
+ std::vector<uint8>* packet) const;
+
+ void BuildReceiverLog(const RtcpReceiverLogMessage* receiver_log_message,
+ std::vector<uint8>* packet) const;
+
inline void BitrateToRembExponentBitrate(uint32 bitrate,
uint8* exponent,
uint32* mantissa) const {

Powered by Google App Engine
This is Rietveld 408576698