Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3215)

Unified Diff: chrome/browser/resources/history/history.js

Issue 707123002: history: announce search/time ranges. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fix Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/history/history.html ('k') | chrome/browser/resources/history/history_mobile.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/history/history.js
diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js
index a3690b01f646a8766df6f39e62e2b1ec75c84f83..e777a223cb6f8c00c5fa592eda25c15c5bf9acc4 100644
--- a/chrome/browser/resources/history/history.js
+++ b/chrome/browser/resources/history/history.js
@@ -1311,7 +1311,11 @@ HistoryView.prototype.clear_ = function() {
if (alertOverlay && alertOverlay.classList.contains('showing'))
hideConfirmationOverlay();
- this.resultDiv_.textContent = '';
+ // Remove everything but <h3 id="results-header"> (the first child).
+ while (this.resultDiv_.children.length > 1) {
+ this.resultDiv_.removeChild(this.resultDiv_.lastElementChild);
+ }
+ $('results-header').textContent = '';
this.currentVisits_.forEach(function(visit) {
visit.isRendered = false;
@@ -1573,13 +1577,19 @@ HistoryView.prototype.displayResults_ = function(doneLoading) {
var groupByDomain = this.model_.getGroupByDomain();
if (searchText) {
- // Add a header for the search results, if there isn't already one.
- if (!this.resultDiv_.querySelector('h3')) {
- var header = document.createElement('h3');
- header.textContent = loadTimeData.getStringF('searchResultsFor',
- searchText);
- this.resultDiv_.appendChild(header);
+ var headerText;
+ if (!doneLoading) {
+ headerText = loadTimeData.getStringF('searchResultsFor', searchText);
+ } else if (results.length == 0) {
+ headerText = loadTimeData.getString('noSearchResults');
+ } else {
+ var resultId = results.length == 1 ? 'searchResult' : 'searchResults';
+ headerText = loadTimeData.getStringF('foundSearchResults',
+ results.length,
+ loadTimeData.getString(resultId),
+ searchText);
}
+ $('results-header').textContent = headerText;
this.addTimeframeInterval_(this.resultDiv_);
@@ -1589,11 +1599,7 @@ HistoryView.prototype.displayResults_ = function(doneLoading) {
if (!this.model_.editingEntriesAllowed)
searchResults.classList.add('no-checkboxes');
- if (results.length == 0 && doneLoading) {
- var noSearchResults = searchResults.appendChild(
- createElementWithClassName('div', 'no-results-message'));
- noSearchResults.textContent = loadTimeData.getString('noSearchResults');
- } else {
+ if (doneLoading) {
for (var i = 0, visit; visit = results[i]; i++) {
if (!visit.isRendered) {
searchResults.appendChild(visit.getResultDOM({
@@ -1610,13 +1616,12 @@ HistoryView.prototype.displayResults_ = function(doneLoading) {
this.addTimeframeInterval_(resultsFragment);
- if (results.length == 0 && doneLoading) {
- var noResults = resultsFragment.appendChild(
- createElementWithClassName('div', 'no-results-message'));
- noResults.textContent = loadTimeData.getString('noResults');
- this.resultDiv_.appendChild(resultsFragment);
+ var noResults = results.length == 0 && doneLoading;
+ $('results-header').textContent = noResults ?
+ loadTimeData.getString('noResults') : '';
+
+ if (noResults)
return;
- }
if (this.getRangeInDays() == HistoryModel.Range.MONTH &&
groupByDomain) {
« no previous file with comments | « chrome/browser/resources/history/history.html ('k') | chrome/browser/resources/history/history_mobile.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698