Issue 7071018: Merge 86845 - Fix hittesting in the OpaqueBrowserFrameView for frames without a tabstrip. The Hi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7071018: Merge 86845 - Fix hittesting in the OpaqueBrowserFrameView for frames without a tabstrip. The Hi... (Closed)

Created:
9 years, 7 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/742/src/

Visibility:
Public.

Description

Merge 86845 - Fix hittesting in the OpaqueBrowserFrameView for frames without a tabstrip. The HitTest() function was using GetBoundsForTabstrip(), which returns the ideal tabstrip bounds assuming a tabstrip were visible, instead of the actual tabstrip bounds. Also cleans up some unnecessarily verbose code. BUG=82524 TEST=Install a Chrome theme. Visit http://www.liveatc.net/search/?icao=ath and click the green "listen" button that "requires Java". A popup window with an infobar should appear. The infobar buttons should be clickable. Review URL: http://codereview.chromium.org/7071001 TBR=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86847

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -18 lines)			Patch
	M	chrome/browser/ui/views/frame/glass_browser_frame_view.cc	View		1 chunk	+4 lines, -7 lines	0 comments	Download
	M	chrome/browser/ui/views/frame/opaque_browser_frame_view.cc	View		3 chunks	+7 lines, -11 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages