Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: src/mark-compact.cc

Issue 7071012: Fix bogus assertion in DiscoverGreyObjectsOnPage. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1373 matching lines...) Expand 10 before | Expand all | Expand 10 after
1384 if (marking_deque->IsFull()) return; 1384 if (marking_deque->IsFull()) return;
1385 } 1385 }
1386 } 1386 }
1387 } 1387 }
1388 1388
1389 1389
1390 static inline int MarkWordToObjectStarts(uint32_t mark_bits, int* starts); 1390 static inline int MarkWordToObjectStarts(uint32_t mark_bits, int* starts);
1391 1391
1392 1392
1393 static void DiscoverGreyObjectsOnPage(MarkingDeque* marking_deque, Page* p) { 1393 static void DiscoverGreyObjectsOnPage(MarkingDeque* marking_deque, Page* p) {
1394 ASSERT(strcmp(Marking::kWhiteBitPattern, "10") == 0); 1394 ASSERT(strcmp(Marking::kWhiteBitPattern, "00") == 0);
1395 ASSERT(strcmp(Marking::kBlackBitPattern, "10") == 0); 1395 ASSERT(strcmp(Marking::kBlackBitPattern, "10") == 0);
1396 ASSERT(strcmp(Marking::kGreyBitPattern, "11") == 0); 1396 ASSERT(strcmp(Marking::kGreyBitPattern, "11") == 0);
1397 ASSERT(strcmp(Marking::kImpossibleBitPattern, "01") == 0); 1397 ASSERT(strcmp(Marking::kImpossibleBitPattern, "01") == 0);
1398 1398
1399 MarkBit::CellType* cells = p->markbits()->cells(); 1399 MarkBit::CellType* cells = p->markbits()->cells();
1400 1400
1401 int last_cell_index = 1401 int last_cell_index =
1402 Bitmap::IndexToCell( 1402 Bitmap::IndexToCell(
1403 Bitmap::CellAlignIndex( 1403 Bitmap::CellAlignIndex(
1404 p->AddressToMarkbitIndex(p->ObjectAreaEnd()))); 1404 p->AddressToMarkbitIndex(p->ObjectAreaEnd())));
(...skipping 1364 matching lines...) Expand 10 before | Expand all | Expand 10 after
2769 } 2769 }
2770 2770
2771 2771
2772 void MarkCompactCollector::Initialize() { 2772 void MarkCompactCollector::Initialize() {
2773 StaticPointersToNewGenUpdatingVisitor::Initialize(); 2773 StaticPointersToNewGenUpdatingVisitor::Initialize();
2774 StaticMarkingVisitor::Initialize(); 2774 StaticMarkingVisitor::Initialize();
2775 } 2775 }
2776 2776
2777 2777
2778 } } // namespace v8::internal 2778 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698