Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 707083002: Add app_installer to archive. (Closed)

Created:
6 years, 1 month ago by jackhou1
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add app_installer to archive. BUG=431134 Committed: https://crrev.com/9b8e30484d6058e449e708d52e32da43cedd2bf0 Cr-Commit-Position: refs/heads/master@{#303250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/tools/build/win/FILES.cfg View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
jackhou1
grt, could you take a look?
6 years, 1 month ago (2014-11-07 00:46:13 UTC) #2
grt (UTC plus 2)
looks good to me, but i defer to mmoss.
6 years, 1 month ago (2014-11-07 02:58:47 UTC) #4
mmoss
lgtm
6 years, 1 month ago (2014-11-07 03:15:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707083002/1
6 years, 1 month ago (2014-11-07 03:23:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22762)
6 years, 1 month ago (2014-11-07 03:27:10 UTC) #10
jackhou1
On 2014/11/07 03:27:10, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 1 month ago (2014-11-07 03:40:24 UTC) #11
Michael Moss
lgtm
6 years, 1 month ago (2014-11-07 17:35:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/707083002/1
6 years, 1 month ago (2014-11-07 17:36:43 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-07 17:41:57 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 17:42:38 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b8e30484d6058e449e708d52e32da43cedd2bf0
Cr-Commit-Position: refs/heads/master@{#303250}

Powered by Google App Engine
This is Rietveld 408576698