pkg/analyzer/lib/src/generated/element_resolver.dart - Issue 707073002: Fix analyzer's treatment of mixin constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/element_resolver.dart

Issue 707073002: Fix analyzer's treatment of mixin constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Improve error message. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/generated/element_resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/element_resolver.dart b/pkg/analyzer/lib/src/generated/element_resolver.dart

index ab9365e3c52393de64e19b7912e08ab43d9b2e57..6b6acec33a6680dc6acc58cde641377fa8d954c0 100644

--- a/pkg/analyzer/lib/src/generated/element_resolver.dart

+++ b/pkg/analyzer/lib/src/generated/element_resolver.dart

@@ -1061,7 +1061,8 @@ class ElementResolver extends SimpleAstVisitor<Object> {

SimpleIdentifier name = node.constructorName;

String superName = name != null ? name.name : null;

ConstructorElement element = superType.lookUpConstructor(superName, _definingLibrary);

- if (element == null) {

+ if (element == null ||

+ !enclosingClass.isSuperConstructorAccessible(element)) {

if (name != null) {

_resolver.reportErrorForNode(CompileTimeErrorCode.UNDEFINED_CONSTRUCTOR_IN_INITIALIZER, node, [superType.displayName, name]);

} else {