Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 707003002: Add MinidumpStringListWriter and test (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@minidump_rva_list
Project:
crashpad
Visibility:
Public.

Description

Add MinidumpStringListWriter and test. TEST=minidump_test MinidumpStringWriter.*List R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/6e97189d2733cb04b3352204b80d10b134fe8ba6

Patch Set 1 #

Patch Set 2 : Add InitializeFromVector() and IsUseful() #

Total comments: 2

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -0 lines) Patch
M minidump/minidump_string_writer.h View 1 2 chunks +64 lines, -0 lines 0 comments Download
M minidump/minidump_string_writer.cc View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
M minidump/minidump_string_writer_test.cc View 1 2 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mark Mentovai
This depends on https://codereview.chromium.org/704333002/.
6 years, 1 month ago (2014-11-06 19:37:41 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/707003002/diff/40001/minidump/minidump_string_writer_test.cc File minidump/minidump_string_writer_test.cc (right): https://codereview.chromium.org/707003002/diff/40001/minidump/minidump_string_writer_test.cc#newcode221 minidump/minidump_string_writer_test.cc:221: template <typename Traits> There's gtest support for this, ...
6 years, 1 month ago (2014-11-07 14:47:01 UTC) #4
Mark Mentovai
https://codereview.chromium.org/707003002/diff/40001/minidump/minidump_string_writer_test.cc File minidump/minidump_string_writer_test.cc (right): https://codereview.chromium.org/707003002/diff/40001/minidump/minidump_string_writer_test.cc#newcode221 minidump/minidump_string_writer_test.cc:221: template <typename Traits> Robert Sesek wrote: > There's gtest ...
6 years, 1 month ago (2014-11-07 14:56:49 UTC) #5
Mark Mentovai
6 years, 1 month ago (2014-11-07 14:57:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
6e97189d2733cb04b3352204b80d10b134fe8ba6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698