components/gcm_driver/gcm_driver_desktop.cc - Issue 706993003: C++ readability review

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_driver_desktop.cc

Issue 706993003: C++ readability review (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/gcm_driver/gcm_driver_desktop.cc

diff --git a/components/gcm_driver/gcm_driver_desktop.cc b/components/gcm_driver/gcm_driver_desktop.cc

index e6d04f54db7fe172f7f8132a4f580316e999b37d..3da6cea4449685a1a0c882424f0166ab4beb527f 100644

--- a/components/gcm_driver/gcm_driver_desktop.cc

+++ b/components/gcm_driver/gcm_driver_desktop.cc

@@ -344,7 +344,7 @@ void GCMDriverDesktop::IOWorker::WakeFromSuspendForHeartbeat(bool wake) {

scoped_ptr<base::Timer> timer;

if (wake)

- timer.reset(new timers::AlarmTimer(true, false));

+ timer.reset(new timers::SimpleAlarmTimer());

else

timer.reset(new base::Timer(true, false));

« no previous file with comments | « no previous file | components/timers.gypi » ('j') | components/timers/alarm_timer.cc » ('J')