components/timers/rtc_alarm.h - Issue 706993003: C++ readability review

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/timers/rtc_alarm.h

Issue 706993003: C++ readability review (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/timers/alarm_timer.h ('K') | « components/timers/alarm_timer_unittest.cc ('k') | components/timers/rtc_alarm.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_TIMER_RTC_ALARM_H_	5 #ifndef COMPONENTS_TIMER_RTC_ALARM_H_

6 #define COMPONENTS_TIMER_RTC_ALARM_H_	6 #define COMPONENTS_TIMER_RTC_ALARM_H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "base/memory/ref_counted.h"	9 #include "base/memory/ref_counted.h"

10 #include "base/memory/scoped_ptr.h"	10 #include "base/memory/scoped_ptr.h"

(...skipping 73 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
84 // parent_->OnTimerFired() only if \|origin_event_id_\| matches the event id	84 // parent_->OnTimerFired() only if \|origin_event_id_\| matches the event id

85 // that was passed in to it. This is used to get around a race condition	85 // that was passed in to it. This is used to get around a race condition

86 // where the user resets the timer on the original thread, while the event is	86 // where the user resets the timer on the original thread, while the event is

87 // being fired on the IO thread at the same time.	87 // being fired on the IO thread at the same time.

88 int origin_event_id_;	88 int origin_event_id_;

89 int io_event_id_;	89 int io_event_id_;

90	90

91 DISALLOW_COPY_AND_ASSIGN(RtcAlarm);	91 DISALLOW_COPY_AND_ASSIGN(RtcAlarm);

92 };	92 };

93	93

	94

94 } // namespace timers	95 } // namespace timers

95 #endif // COMPONENTS_TIMER_RTC_ALARM_H_	96 #endif // COMPONENTS_TIMER_RTC_ALARM_H_

OLD	NEW