components/timers/alarm_timer.h - Issue 706993003: C++ readability review

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/timers/alarm_timer.h

Issue 706993003: C++ readability review (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | components/timers/alarm_timer.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_TIMER_ALARM_TIMER_H_	5 #ifndef COMPONENTS_TIMER_ALARM_TIMER_H_

6 #define COMPONENTS_TIMER_ALARM_TIMER_H_	6 #define COMPONENTS_TIMER_ALARM_TIMER_H_

7	7

8 #include "base/callback.h"	8 #include "base/callback.h"

9 #include "base/macros.h"	9 #include "base/macros.h"

10 #include "base/memory/ref_counted.h"	10 #include "base/memory/ref_counted.h"

(...skipping 84 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
95 // destruction of that message loop.	95 // destruction of that message loop.

96 base::MessageLoop* origin_message_loop_;	96 base::MessageLoop* origin_message_loop_;

97	97

98 base::WeakPtrFactory<AlarmTimer> weak_factory_;	98 base::WeakPtrFactory<AlarmTimer> weak_factory_;

99	99

100 DISALLOW_COPY_AND_ASSIGN(AlarmTimer);	100 DISALLOW_COPY_AND_ASSIGN(AlarmTimer);

101 };	101 };

102	102

103 } // namespace timers	103 } // namespace timers

104	104

	105
	Daniel Erat 2014/11/06 20:43:15 what are the extra blank lines here and in the oth what are the extra blank lines here and in the other files for? i think that pretty much all chromium code that i've seen has exactly one blank line between the end of the namespace and the closing header guard. Chirantan Ekbote 2014/11/06 20:45:34 I had to make a whitespace change so that git woul Show quoted text On 2014/11/06 20:43:15, Daniel Erat wrote: > what are the extra blank lines here and in the other files for? i think that > pretty much all chromium code that i've seen has exactly one blank line between > the end of the namespace and the closing header guard. I had to make a whitespace change so that git would include each file in the commit. They'll be removed before this CL is submitted.
105 #endif // COMPONENTS_TIMER_ALARM_TIMER_H_	106 #endif // COMPONENTS_TIMER_ALARM_TIMER_H_

OLD	NEW