components/timers/alarm_timer.cc - Issue 706993003: C++ readability review

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/timers/alarm_timer.cc

Issue 706993003: C++ readability review (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/timers/alarm_timer.h"	5 #include "components/timers/alarm_timer.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/bind_helpers.h"	8 #include "base/bind_helpers.h"

9 #include "base/files/file_util.h"	9 #include "base/files/file_util.h"

10 #include "base/logging.h"	10 #include "base/logging.h"

(...skipping 106 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
117 if (base::Timer::is_repeating())	117 if (base::Timer::is_repeating())

118 Reset();	118 Reset();

119 else	119 else

120 Stop();	120 Stop();

121	121

122 // Now run the user task.	122 // Now run the user task.

123 base::MessageLoop::current()->task_annotator()->RunTask(	123 base::MessageLoop::current()->task_annotator()->RunTask(

124 "AlarmTimer::Reset", "AlarmTimer::OnTimerFired", *pending_user_task);	124 "AlarmTimer::Reset", "AlarmTimer::OnTimerFired", *pending_user_task);

125 }	125 }

126	126

	127

127 } // namespace timers	128 } // namespace timers

OLD	NEW