Source/core/rendering/RenderGrid.h - Issue 706903003: [CSS Grid Layout] Partial implementation of justify-content for Grid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderGrid.h

Issue 706903003: [CSS Grid Layout] Partial implementation of justify-content for Grid. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Don't assert flex tracks exhaust the availableFreeSpace Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderGrid.h

diff --git a/Source/core/rendering/RenderGrid.h b/Source/core/rendering/RenderGrid.h

index cddb42315649507a9b19fc1e78c205724edb1647..07f397d7287f3f2ef17eb15c7286543fb3d106c1 100644

--- a/Source/core/rendering/RenderGrid.h

+++ b/Source/core/rendering/RenderGrid.h

@@ -96,7 +96,7 @@ private:

GridTrackSizingDirection autoPlacementMinorAxisDirection() const;

void layoutGridItems();

- void populateGridPositions(const GridSizingData&);

+ void populateGridPositions(const GridSizingData&, LayoutUnit availableSpaceForColumns, LayoutUnit availableSpaceForRows);

typedef LayoutUnit (RenderGrid::* SizingFunction)(RenderBox&, GridTrackSizingDirection, Vector<GridTrack>&);

typedef LayoutUnit (GridTrack::* AccumulatorGetter)() const;

@@ -122,6 +122,7 @@ private:

LayoutUnit endOfRowForChild(const RenderBox& child) const;

LayoutUnit centeredRowPositionForChild(const RenderBox&) const;

LayoutUnit rowPositionForChild(const RenderBox&) const;

+ LayoutUnit contentPositionAndDistributionOffset(LayoutUnit availableFreeSpace, ContentPosition, ContentDistributionType, unsigned numberOfItems) const;

LayoutPoint findChildLogicalPosition(const RenderBox&) const;

GridCoordinate cachedGridCoordinate(const RenderBox&) const;

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-justify-content-expected.txt ('k') | Source/core/rendering/RenderGrid.cpp » ('j') | no next file with comments »