Non-path Time Machine Exclusions

Non-path Time Machine Exclusions

Enable setting of file exclusion for non-admin/non-root users. We no longer support setting exclusion-by-path.
Enhanced error reporting in SetFileBackupExclusion.
Change exclusion calls for History and Thumbnail databases.
Made MacUtilTest.TestExcludeFileFromBackups more robust.

BUG=74053
TEST=Updated base_unittests's MacUtilTest.TestExcludeFileFromBackups.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86778

[mrossetti, 2011-05-25 18:57:17]

I decided to break apart the exclusion change in the Mac utilities form that in
SQLite.

[Mark Mentovai, 2011-05-25 19:19:05]

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util.mm
File base/mac/mac_util.mm (right):

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util.mm#newcode251
base/mac/mac_util.mm:251: OSStatus os_err =
CSBackupSetItemExcluded((CFURLRef)url, true, false);
Instead of CFURLRef, use NSToCFCast from "base/mac/foundation_util.h".

For the other two arguments, use TRUE and FALSE.

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm
File base/mac/mac_util_unittest.mm (right):

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm#n...
base/mac/mac_util_unittest.mm:100: &temp_dir));
Who’s responsible for cleaning up temp_dir? Maybe use ScopedTempDir from
"base/scoped_temp_dir.h" here.

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm#n...
base/mac/mac_util_unittest.mm:103: FILE* dummy_file =
file_util::OpenFile(dummy_file_path, "w");
Put this in a file_util::ScopedFILE to ensure it closes? ("base/file_util.h")

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm#n...
base/mac/mac_util_unittest.mm:105: const char dummy_data[] = "All your base are
belong to us!";
:)

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm#n...
base/mac/mac_util_unittest.mm:106: EXPECT_TRUE(fwrite(dummy_data,
ARRAYSIZE_UNSAFE(dummy_data), 1, dummy_file));
Instead of file_util::OpenFile + fwrite + file_util::CloseFile (or
file_util::ScopedFILE), how about just using file_util::WriteFile?

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm#n...
base/mac/mac_util_unittest.mm:106: EXPECT_TRUE(fwrite(dummy_data,
ARRAYSIZE_UNSAFE(dummy_data), 1, dummy_file));
The “safe” arraysize didn’t work here?

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm#n...
base/mac/mac_util_unittest.mm:112:
EXPECT_FALSE(CSBackupIsItemExcluded((CFURLRef)fileURL, NULL));
I wonder if this is always true in the temp directory you wind up in.

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm#n...
base/mac/mac_util_unittest.mm:116: Boolean excluded_by_path = false;
FALSE

[mrossetti, 2011-05-25 21:12:31]

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util.mm
File base/mac/mac_util.mm (right):

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util.mm#newcode251
base/mac/mac_util.mm:251: OSStatus os_err =
CSBackupSetItemExcluded((CFURLRef)url, true, false);
On 2011/05/25 19:19:06, Mark Mentovai wrote:
> Instead of CFURLRef, use NSToCFCast from "base/mac/foundation_util.h".
> 
> For the other two arguments, use TRUE and FALSE.

Done.

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm
File base/mac/mac_util_unittest.mm (right):

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm#n...
base/mac/mac_util_unittest.mm:100: &temp_dir));
On 2011/05/25 19:19:06, Mark Mentovai wrote:
> Who’s responsible for cleaning up temp_dir? Maybe use ScopedTempDir from
> "base/scoped_temp_dir.h" here.

Done.

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm#n...
base/mac/mac_util_unittest.mm:103: FILE* dummy_file =
file_util::OpenFile(dummy_file_path, "w");
On 2011/05/25 19:19:06, Mark Mentovai wrote:
> Put this in a file_util::ScopedFILE to ensure it closes? ("base/file_util.h")

Eliminated in favor of just using WriteFile.

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm#n...
base/mac/mac_util_unittest.mm:106: EXPECT_TRUE(fwrite(dummy_data,
ARRAYSIZE_UNSAFE(dummy_data), 1, dummy_file));
On 2011/05/25 19:19:06, Mark Mentovai wrote:
> Instead of file_util::OpenFile + fwrite + file_util::CloseFile (or
> file_util::ScopedFILE), how about just using file_util::WriteFile?

Done.

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm#n...
base/mac/mac_util_unittest.mm:106: EXPECT_TRUE(fwrite(dummy_data,
ARRAYSIZE_UNSAFE(dummy_data), 1, dummy_file));
On 2011/05/25 19:19:06, Mark Mentovai wrote:
> The “safe” arraysize didn’t work here?

Done.

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm#n...
base/mac/mac_util_unittest.mm:112:
EXPECT_FALSE(CSBackupIsItemExcluded((CFURLRef)fileURL, NULL));
On 2011/05/25 19:19:06, Mark Mentovai wrote:
> I wonder if this is always true in the temp directory you wind up in.

It might be different under 10.7 but it comes up non-excluded here and then
excluded below.

http://codereview.chromium.org/7069021/diff/1/base/mac/mac_util_unittest.mm#n...
base/mac/mac_util_unittest.mm:116: Boolean excluded_by_path = false;
On 2011/05/25 19:19:06, Mark Mentovai wrote:
> FALSE

Yeah, yeah — I'm getting it.  ;^)

[Mark Mentovai, 2011-05-25 21:15:21]

LGTM

http://codereview.chromium.org/7069021/diff/4002/base/mac/mac_util_unittest.mm
File base/mac/mac_util_unittest.mm (right):

http://codereview.chromium.org/7069021/diff/4002/base/mac/mac_util_unittest.m...
base/mac/mac_util_unittest.mm:111:
EXPECT_FALSE(CSBackupIsItemExcluded((CFURLRef)fileURL, NULL));
base::mac::CFToNSCast here too.