Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 706873002: [chrome/browser/download] Convert VLOGs to DVLOGs (Closed)

Created:
6 years, 1 month ago by anujsharma
Modified:
6 years, 1 month ago
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chrome/browser/download] Convert VLOGs to DVLOGs BUG=101424 Committed: https://crrev.com/b5b25455ca2db83772804caaf447c3370aa2fb63 Cr-Commit-Position: refs/heads/master@{#303178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M chrome/browser/download/chrome_download_manager_delegate.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/download/download_status_updater_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
anujsharma
PTAL
6 years, 1 month ago (2014-11-06 11:48:58 UTC) #2
Paweł Hajdan Jr.
Deferring to Randy.
6 years, 1 month ago (2014-11-06 13:29:48 UTC) #4
anujsharma
@rdsmith - PTAL
6 years, 1 month ago (2014-11-06 13:45:52 UTC) #5
Randy Smith (Not in Mondays)
lgtm
6 years, 1 month ago (2014-11-06 16:02:42 UTC) #6
anujsharma
On 2014/11/06 16:02:42, rdsmith wrote: > lgtm Thanks rdsmith for lgtm.
6 years, 1 month ago (2014-11-07 02:41:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706873002/1
6 years, 1 month ago (2014-11-07 02:43:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-07 03:34:41 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 03:35:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5b25455ca2db83772804caaf447c3370aa2fb63
Cr-Commit-Position: refs/heads/master@{#303178}

Powered by Google App Engine
This is Rietveld 408576698