Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 706863003: [turbofan] Lower asm.js truncations to JSToNumber. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower asm.js truncations to JSToNumber. - JSBitwiseOr(x, 0) => Word32Or(NumberToInt32(JSToNumber(x)), 0) - JSMultiply(x, 1) => NumberMultiply(JSToNumber(x), 1) R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25198

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -4 lines) Patch
M src/compiler/js-typed-lowering.h View 1 3 chunks +5 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 4 chunks +42 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 1 month ago (2014-11-06 12:37:34 UTC) #1
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-06 12:38:43 UTC) #2
Jarin
lgtm
6 years, 1 month ago (2014-11-06 13:52:42 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-06 13:55:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25198 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698