Stub out ServiceWorkerRegistration and Version classes

content/browser/service_worker/service_worker_registration.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTRATION_H_
+#define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTRATION_H_
+
+#include "base/basictypes.h"
+#include "base/gtest_prod_util.h"
+#include "base/logging.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "content/browser/service_worker/service_worker_version.h"
+#include "content/common/content_export.h"
+
+class GURL;
+
+namespace content {
+
+class ServiceWorkerVersion;
+
+// This class acts as a persistent instance

[michaeln, 2013/11/13 01:53:24]

This class comment and the other could use some work.

+class CONTENT_EXPORT ServiceWorkerRegistration
+    : NON_EXPORTED_BASE(public base::RefCounted<ServiceWorkerRegistration>) {
+ public:
+  ServiceWorkerRegistration(const GURL& pattern,
+                            const GURL& script_url,
+                            int64 registration_id);
+
+  int64 id() const { return registration_id_; }

[michaeln, 2013/11/13 01:53:24]

maybe a const getter for 'pattern' too and co-locate the unix-hacker-style
getters

[alecflett, 2013/11/13 18:28:24]

Done.

+
+  void Shutdown();
+
+  const GURL& script_url() const { return script_url_; }
+
+  scoped_refptr<ServiceWorkerVersion> active_version() const {
+    DCHECK(!is_shutdown_);

[michaeln, 2013/11/13 01:53:24]

dcheck'ing the setters seems useful, we don't dcheck in the other one-line
getters..

ServiceWorkerVersion* active_version() const { return active_version_; }

[alecflett, 2013/11/13 18:28:24]

I suspect that we might want access to things like the id / script_url / pattern
during shutdown, but accessing the various ServiceWorkerVersions seems wrong.
I'd rather ad additional DCHECKs than remove the ones that are there

+    return active_version_.get();
+  }
+
+  scoped_refptr<ServiceWorkerVersion> in_waiting_version() const {

[michaeln, 2013/11/13 01:53:24]

Terminology... wdyt of using the term "pending" instead of "in_waiting"?

And does ServiceWorkerVersion* work as a return value here?

[alecflett, 2013/11/13 18:28:24]

SGTM
Why? I mean if we're using refcounting, we should just use it right? I found
lots of precedent  for it:
https://code.google.com/p/chromium/codesearch#search/&q=%5E%5C%20*scoped_refp...

+    DCHECK(!is_shutdown_);
+    return in_waiting_version_;
+  }
+
+  void set_active_version(scoped_refptr<ServiceWorkerVersion> version) {

[michaeln, 2013/11/13 01:53:24]

Does ServiceWorkerVersion* work as a parameter here?

[alecflett, 2013/11/13 18:28:24]

I did however switch the setters to take a const scoped_refptr<> to avoid
refcount churn... 

+    DCHECK(!is_shutdown_);
+    active_version_ = version;
+  }
+
+  void set_in_waiting_version(scoped_refptr<ServiceWorkerVersion> version) {
+    DCHECK(!is_shutdown_);
+    in_waiting_version_ = version;
+  }
+
+  // The final synchronous switchover after all events have been
+  // fired, and the old "active version" is being shut down.
+  void ActivateInWaitingVersion();
+
+ private:
+  virtual ~ServiceWorkerRegistration();
+  friend class base::RefCounted<ServiceWorkerRegistration>;
+  FRIEND_TEST_ALL_PREFIXES(ServiceWorkerRegistrationTest, Shutdown);
+  FRIEND_TEST_ALL_PREFIXES(ServiceWorkerRegistrationTest, ActivateFirst);
+  FRIEND_TEST_ALL_PREFIXES(ServiceWorkerRegistrationTest, ActivateInWaiting);
+
+  bool IsShutdown() const { return is_shutdown_; }

[michaeln, 2013/11/13 01:53:24]

why is this one not unix-hacker-style? also since its a private method consumers
could just test the is_shutdown_ member w/o the having a getter

[alecflett, 2013/11/13 18:28:24]

good point. I moved this to be public, which let me remove the FRIEND_TEST*
declarations.

+
+  const GURL& pattern_;
+  const GURL& script_url_;
+  const int64 registration_id_;
+
+  scoped_refptr<ServiceWorkerVersion> active_version_;
+  scoped_refptr<ServiceWorkerVersion> in_waiting_version_;
+
+  bool is_shutdown_;
+
+  DISALLOW_COPY_AND_ASSIGN(ServiceWorkerRegistration);
+};
+}  // namespace content
+#endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTRATION_H_