src/native_client/src/trusted/service_runtime/sel_ldr.h - Issue 7068021: Dynamic loading: Fill pages with halts only when they are needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/native_client/src/trusted/service_runtime/sel_ldr.h

Issue 7068021: Dynamic loading: Fill pages with halts only when they are needed (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Fix log messages Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/native_client/src/trusted/service_runtime/sel_addrspace.c ('k') | src/native_client/src/trusted/service_runtime/sel_ldr.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/native_client/src/trusted/service_runtime/sel_ldr.h

diff --git a/src/native_client/src/trusted/service_runtime/sel_ldr.h b/src/native_client/src/trusted/service_runtime/sel_ldr.h

index 374e4d9d91c8e95ed452b99e8e52d5beb1103b86..7c69692a139004b75811d35d3c6f958f329b96f1 100644

--- a/src/native_client/src/trusted/service_runtime/sel_ldr.h

+++ b/src/native_client/src/trusted/service_runtime/sel_ldr.h

@@ -247,6 +247,12 @@ struct NaClApp {

int use_shm_for_dynamic_text;

struct NaClDesc *text_shm;

struct NaClMutex dynamic_load_mutex;

+ /*

+ * This records which pages in text_shm have been allocated. When a

+ * page is allocated, it is filled with halt instructions and then

+ * made executable by untrusted code.

+ */

+ uint8_t *dynamic_page_bitmap;

* The array of dynamic_regions is maintained in sorted order