Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: src/native_client/src/trusted/desc/nacl_desc_imc_shm.c

Issue 7068021: Dynamic loading: Fill pages with halts only when they are needed (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Fix log messages Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/native_client/src/trusted/desc/nacl_desc_imc_shm.c
diff --git a/src/native_client/src/trusted/desc/nacl_desc_imc_shm.c b/src/native_client/src/trusted/desc/nacl_desc_imc_shm.c
index 5924d4de4a75aaba95f497c4aa865f81e5869cbb..deeb5668d37730496445699e27a8e2d99418d562 100644
--- a/src/native_client/src/trusted/desc/nacl_desc_imc_shm.c
+++ b/src/native_client/src/trusted/desc/nacl_desc_imc_shm.c
@@ -143,12 +143,8 @@ static uintptr_t NaClDescImcShmMap(struct NaClDesc *vself,
/* post-condition: if NULL == start_addr, then NACL_ABI_MAP_FIXED not set */
/*
- * prot must be not be PROT_NONE nor contain other than PROT_{READ|WRITE}
+ * prot must not contain bits other than PROT_{READ|WRITE|EXEC}.
*/
- if (NACL_ABI_PROT_NONE == prot) {
- NaClLog(LOG_INFO, "NaClDescImcShmMap: PROT_NONE not supported\n");
- return -NACL_ABI_EINVAL;
- }
if (0 != (~(NACL_ABI_PROT_READ | NACL_ABI_PROT_WRITE | NACL_ABI_PROT_EXEC)
& prot)) {
NaClLog(LOG_INFO,
« no previous file with comments | « src/native_client/src/shared/imc/win/nacl_shm.cc ('k') | src/native_client/src/trusted/service_runtime/nacl_text.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698