Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 706763003: x11: Always require XI2.2 for X11. (Closed)

Created:
6 years, 1 month ago by sadrul
Modified:
5 years, 9 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, tdresser+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

x11: Always require XI2.2 for X11. This removes the use_xi2_mt gyp variable, and USE_XI2_MT define from the code. XI2.2 is now available on all supported linux platforms. BUG=291141 R=brettw@chromium.org, derat@chromium.org, erg@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4ae87941c77264d9271afdf939381962c4f45bd2

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : tot-merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -81 lines) Patch
M ash/touch/touch_hud_debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_uma.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M build/common.gypi View 1 2 3 chunks +0 lines, -10 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/ui.gni View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_tree_host_x11.cc View 5 chunks +0 lines, -6 lines 0 comments Download
M ui/events/devices/x11/device_data_manager_x11.cc View 3 chunks +5 lines, -16 lines 0 comments Download
M ui/events/devices/x11/touch_factory_x11.cc View 7 chunks +2 lines, -10 lines 0 comments Download
M ui/events/event_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/platform/x11/x11_event_source.cc View 1 2 1 chunk +3 lines, -10 lines 0 comments Download
M ui/events/platform/x11/x11_hotplug_event_handler.cc View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
M ui/events/x/events_x.cc View 6 chunks +0 lines, -6 lines 0 comments Download
M ui/events/x/events_x_unittest.cc View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
sadrul
6 years, 1 month ago (2014-11-11 21:30:57 UTC) #2
Daniel Erat
lgtm
6 years, 1 month ago (2014-11-11 22:12:25 UTC) #3
sadrul
-eglaysher@ +erg@
6 years, 1 month ago (2014-11-11 23:47:34 UTC) #5
sadrul
brettw@chromium.org: Please review changes in //build/config
6 years, 1 month ago (2014-11-11 23:50:30 UTC) #7
brettw
BUILD.gn LGTM
6 years, 1 month ago (2014-11-12 05:31:26 UTC) #8
Elliot Glaysher
lgtm
6 years, 1 month ago (2014-11-12 18:28:55 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4ae87941c77264d9271afdf939381962c4f45bd2 Cr-Commit-Position: refs/heads/master@{#303918}
6 years, 1 month ago (2014-11-12 23:23:06 UTC) #10
sadrul
Committed patchset #3 (id:40001) manually as 4ae87941c77264d9271afdf939381962c4f45bd2 (presubmit successful).
6 years, 1 month ago (2014-11-12 23:23:11 UTC) #11
dmazzoni
5 years, 9 months ago (2015-03-18 20:37:11 UTC) #13
Message was sent while issue was closed.
Is it possible this is the cause of http://crbug.com/456222? Lots of Linux users
are reporting a major regression for almost anything involving the mouse when
using Virtualbox.

This change was in the bisect.

Powered by Google App Engine
This is Rietveld 408576698