Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 706753003: Add remoting_host target to chromium_builder_webrtc dependencies. (Closed)

Created:
6 years, 1 month ago by kjellander_chromium
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add remoting_host target to chromium_builder_webrtc dependencies. This will make it possible for us to catch compile failures in the remoting_host component when rolling the WebRTC and libjingle revisions in Chromium DEPS using the bots in http://build.chromium.org/p/chromium.webrtc.fyi/waterfall Committed: https://crrev.com/32e1bf6e3fcc38662eb1dd1b0a1a2739a95992ec Cr-Commit-Position: refs/heads/master@{#303436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kjellander_chromium
6 years, 1 month ago (2014-11-07 17:28:59 UTC) #2
perkj_chrome
Thanks for doing this. lgtm nit: please remove the bug=
6 years, 1 month ago (2014-11-10 08:10:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706753003/1
6 years, 1 month ago (2014-11-10 08:27:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-10 09:36:20 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/32e1bf6e3fcc38662eb1dd1b0a1a2739a95992ec Cr-Commit-Position: refs/heads/master@{#303436}
6 years, 1 month ago (2014-11-10 09:36:57 UTC) #7
Nikita (slow)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/713023002/ by nkostylev@chromium.org. ...
6 years, 1 month ago (2014-11-10 13:11:47 UTC) #8
Nikita (slow)
6 years, 1 month ago (2014-11-10 14:35:50 UTC) #10
Message was sent while issue was closed.
revert helped:

before http://goo.gl/TJRBMo
after http://goo.gl/i6zGDK

Powered by Google App Engine
This is Rietveld 408576698