Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 706703005: Allow JSArray fast moving elements even if the array's proto isn't Array.prototype in original state (Closed)

Created:
6 years, 1 month ago by Toon Verwaest
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Allow JSArray fast moving elements even if the array's proto isn't Array.prototype in original state Otherwise array builtins don't work on internal arrays. BUG=v8:3681 LOG=n R=machenbach@chromium.org, mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25190

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Cleanup #

Patch Set 4 : revert disabling of json2 test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -27 lines) Patch
M src/builtins.cc View 1 2 3 chunks +13 lines, -23 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Toon Verwaest
PTAL
6 years, 1 month ago (2014-11-06 12:19:58 UTC) #2
Michael Achenbach
lgtm for the status file
6 years, 1 month ago (2014-11-06 12:53:10 UTC) #3
mvstanton
LGTM.
6 years, 1 month ago (2014-11-06 12:53:24 UTC) #4
Toon Verwaest
6 years, 1 month ago (2014-11-06 12:55:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 25190 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698