views/controls/textfield/native_textfield_views_unittest.cc - Issue 7067015: An edit for SetText needs to be merged with previous edit for omnibox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/controls/textfield/native_textfield_views_unittest.cc

Issue 7067015: An edit for SetText needs to be merged with previous edit for omnibox. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: " Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: views/controls/textfield/native_textfield_views_unittest.cc

diff --git a/views/controls/textfield/native_textfield_views_unittest.cc b/views/controls/textfield/native_textfield_views_unittest.cc

index b213240de21ade87ba2f531a1c5121d71d5823ab..f94f1263ae2dd996c37a1ba75d64fb0f13f2776e 100644

--- a/views/controls/textfield/native_textfield_views_unittest.cc

+++ b/views/controls/textfield/native_textfield_views_unittest.cc

@@ -1021,11 +1021,11 @@ TEST_F(NativeTextfieldViewsTest, UndoRedoTest) {

SendKeyEvent(ui::VKEY_Z, false, true);

EXPECT_STR_EQ("123", textfield_->text());

SendKeyEvent(ui::VKEY_Z, false, true);

- EXPECT_STR_EQ("abc", textfield_->text());

- SendKeyEvent(ui::VKEY_Z, false, true);

EXPECT_STR_EQ("ab", textfield_->text());

msw 2011/06/02 21:02:57 Cool, I get why from your response, maybe add a co

oshima 2011/06/03 00:39:24 Done.

+ SendKeyEvent(ui::VKEY_Z, false, true);

+ EXPECT_STR_EQ("a", textfield_->text());

SendKeyEvent(ui::VKEY_Y, false, true);

- EXPECT_STR_EQ("abc", textfield_->text());

+ EXPECT_STR_EQ("ab", textfield_->text());

SendKeyEvent(ui::VKEY_Y, false, true);

EXPECT_STR_EQ("123", textfield_->text());

SendKeyEvent(ui::VKEY_Y, false, true);

@@ -1069,6 +1069,7 @@ TEST_F(NativeTextfieldViewsTest, UndoRedoTest) {

// Insert

textfield_->SetText(ASCIIToUTF16("123"));

+ SendKeyEvent(ui::VKEY_HOME);

SendKeyEvent(ui::VKEY_INSERT);

SendKeyEvent(ui::VKEY_A);

EXPECT_STR_EQ("a23", textfield_->text());