An edit for SetText needs to be merged with previous edit for omnibox.

views/controls/textfield/textfield_views_model.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_VIEWS_MODEL_H_
 #define VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_VIEWS_MODEL_H_
 #pragma once
 
 #include <list>
 #include <vector>
@@ skipping 16 matching lines @@
 
 class TextStyle;
 typedef std::vector<TextStyle*> TextStyles;
 
 namespace internal {
 // Internal Edit class that keeps track of edits for undo/redo.
 class Edit;
 
 struct TextStyleRange;
 
+// C++ doesn't allow forward decl enum, so let's define here.
+enum MergeType {
+  // The edit should not be merged with next edit. It still may
+  // be merged with an edit with MERGE_WITH_PREVIOUS.
+  DO_NOT_MERGE,  // Never merge

[msw, 2011/06/02 21:02:57]

nit: remove "never merge", the comment above is better.

[oshima, 2011/06/03 00:39:24]

Done.

+  // The edit can be merged with next edit when possible.
+  MERGEABLE,
+  // Does the edit has to be merged with previous edit?

[msw, 2011/06/02 21:02:57]

*have* to be

[oshima, 2011/06/03 00:39:24]

Done.

+  // This forces the merge even if the previous edit is marked
+  // as DO_NOT_MERGE.
+  MERGE_WITH_PREVIOUS,
+};
+
 }  // namespace internal
 
 typedef std::vector<internal::TextStyleRange*> TextStyleRanges;
 
 // A model that represents a text content for TextfieldViews.
 // It supports editing, selection and cursor manipulation.
 class TextfieldViewsModel {
  public:
 
   // Delegate interface implemented by the textfield view class to provided
@@ skipping 259 matching lines @@
   void ReplaceTextInternal(const string16& text, bool mergeable);
 
   // Clears all edit history.
   void ClearEditHistory();
 
   // Clears redo history.
   void ClearRedoHistory();
 
   // Executes and records edit operations.
   void ExecuteAndRecordDelete(size_t from, size_t to, bool mergeable);
-  void ExecuteAndRecordReplace(const string16& text, bool mergeable);
-  void ExecuteAndRecordReplaceAt(const string16& text,
-                                 size_t at,
-                                 bool mergeable);
+  void ExecuteAndRecordReplaceSelection(internal::MergeType merge_type,
+                                        const string16& text);
+  void ExecuteAndRecordReplace(internal::MergeType merge_type,
+                               size_t old_cursor_pos,
+                               size_t new_cursor_pos,
+                               const string16& text,
+                               size_t new_text_start);
   void ExecuteAndRecordInsert(const string16& text, bool mergeable);
 
   // Adds or merge |edit| into edit history. Return true if the edit
   // has been merged and must be deleted after redo.
   bool AddOrMergeEditHistory(internal::Edit* edit);
 
   // Modify the text buffer in following way:
   // 1) Delete the string from |delete_from| to |delte_to|.
   // 2) Insert the |new_text| at the index |new_text_insert_at|.
   //    Note that the index is after deletion.
@@ skipping 58 matching lines @@
 
   // List of style ranges for composition text.
   TextStyleRanges composition_style_ranges_;
 
   DISALLOW_COPY_AND_ASSIGN(TextfieldViewsModel);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_VIEWS_MODEL_H_