Fixed detection of WS_OVERLAPPED windows, bug introduced in change 6561311.

Fixed detection of WS_OVERLAPPED windows, bug introduced in change 6561311.

WS_OVERLAPPED is not a flag, it is zero. Code was added that detects it
as a flag, using '&'. This bug was detected by VC++'s /analyze, giving
this warning:

src\ui\views\win\hwnd_message_handler.cc(874) : warning C6313:
Incorrect operator:  zero-valued flag cannot be tested with bitwise-and.

BUG=427616
Committed: https://crrev.com/26b57c28c3d5d0b540095a0e081bf303163ea76b
Cr-Commit-Position: refs/heads/master@{#302880}

[brucedawson, 2014-11-05 18:19:38]

brucedawson@chromium.org changed reviewers:
+ jackhou@chromium.org, sadrul@chromium.org

[brucedawson, 2014-11-05 18:19:38]

I've been running VC++'s /analyze on Chrome and it found this bug. The early-out
code added in change 6561311 will *always* be taken. This bug is only about six
weeks old so presumably the implications of fixing it aren't too severe.

But, any comments on the risks?

I found the recommended way to test for WS_OVERLAPPED here:

http://forums.codeguru.com/showthread.php?359686-WS_OVERLAPPED-style

[sadrul, 2014-11-05 19:06:10]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org
- sadrul@chromium.org

[sadrul, 2014-11-05 19:06:11]

Windows: sadrul@ --> sky@

[sky, 2014-11-05 20:17:52]

sky@chromium.org changed reviewers:
+ ananta@chromium.org

[sky, 2014-11-05 20:17:53]

+ananta

[ananta, 2014-11-05 20:22:22]

lgtm

[sky, 2014-11-05 20:25:19]

LGTM

[brucedawson, 2014-11-05 20:56:13]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2014-11-05 20:57:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/706643002/1

[commit-bot: I haz the power, 2014-11-05 21:57:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-05 21:57:48]

Patchset 1 (id:??) landed as
https://crrev.com/26b57c28c3d5d0b540095a0e081bf303163ea76b
Cr-Commit-Position: refs/heads/master@{#302880}