Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1969)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 706623004: Add minimum version to extension management (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ext-update-url
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/resources/extensions/extensions.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 7546db1fbb9af1c0716bcdf5bd26c7fb8ae2679e..77c4debbf16468d2ebda25f5d4e0b2209e65783d 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -52,6 +52,7 @@
* runtimeErrors: (Array.<RuntimeError>|undefined),
* suspiciousInstall: boolean,
* terminated: boolean,
+ * updateRequiredByPolicy: boolean,
* version: string,
* views: Array.<{renderViewId: number, renderProcessId: number,
* path: string, incognito: boolean,
@@ -175,7 +176,9 @@ cr.define('options', function() {
node.classList.add('may-not-remove');
} else if (extension.recommendedInstall) {
node.classList.add('may-not-remove');
- } else if (extension.suspiciousInstall || extension.corruptInstall) {
+ } else if (extension.suspiciousInstall ||
+ extension.corruptInstall ||
+ extension.updateRequiredByPolicy) {
node.classList.add('may-not-modify');
}
@@ -356,6 +359,7 @@ cr.define('options', function() {
var enableCheckboxDisabled = extension.managedInstall ||
extension.suspiciousInstall ||
extension.corruptInstall ||
+ extension.updateRequiredByPolicy ||
extension.dependentExtensions.length > 0;
enable.querySelector('input').disabled = enableCheckboxDisabled;
@@ -424,6 +428,16 @@ cr.define('options', function() {
}
}
+ // Then the 'An update required by enterprise policy' message. Note that
+ // a force-installed extension might be disabled due to being outdated
+ // as well.
+ if (extension.updateRequiredByPolicy) {
+ node.querySelector('.update-required-message').hidden = false;
+ // We would like to hide managed installed message since this
+ // extension is disabled.
+ node.querySelector('.managed-message').hidden = true;
+ }
+
if (extension.dependentExtensions.length > 0) {
var dependentMessage =
node.querySelector('.dependent-extensions-message');
« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/resources/extensions/extensions.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698