Add minimum version to extension management

chrome/browser/resources/extensions/extension_list.js

Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 7546db1fbb9af1c0716bcdf5bd26c7fb8ae2679e..5f124270d492193383d3eb78d10eb23a87fb8a2c 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -52,6 +52,7 @@
  *            runtimeErrors: (Array.<RuntimeError>|undefined),
  *            suspiciousInstall: boolean,
  *            terminated: boolean,
+ *            updateRequiredByPolicy: boolean,
  *            version: string,
  *            views: Array.<{renderViewId: number, renderProcessId: number,
  *                path: string, incognito: boolean,
@@ -175,7 +176,8 @@ cr.define('options', function() {
         node.classList.add('may-not-remove');
       } else if (extension.recommendedInstall) {
         node.classList.add('may-not-remove');
-      } else if (extension.suspiciousInstall || extension.corruptInstall) {
+      } else if (extension.suspiciousInstall || extension.corruptInstall ||
+                 extension.updateRequiredByPolicy) {

[Finnur, 2014/11/19 10:16:26]

nit: Lets do three lines here, instead of two.

[binjin, 2014/11/19 13:36:11]

Done.

         node.classList.add('may-not-modify');
       }
 
@@ -356,6 +358,7 @@ cr.define('options', function() {
         var enableCheckboxDisabled = extension.managedInstall ||
                                      extension.suspiciousInstall ||
                                      extension.corruptInstall ||
+                                     extension.updateRequiredByPolicy ||
                                      extension.dependentExtensions.length > 0;
         enable.querySelector('input').disabled = enableCheckboxDisabled;
 
@@ -424,6 +427,13 @@ cr.define('options', function() {
         }
       }
 
+      // Then the 'An update required by enterprise policy' message. Note that
+      // an force installed extension might be disabled due to being outdated

[Finnur, 2014/11/19 10:16:26]

s/an/a/
s/force installed/force-installed/

Is there a message somewhere saying "this extension is required by your admin"?
If so, should we hide that, while this message is visible?

[binjin, 2014/11/19 13:36:11]

Done. I prefer to show both message so that user are aware of the conflict.
Maybe we can tell additional details in this case?

[Finnur, 2014/11/19 15:47:39]

You got the wrong An->a conversion there (I was referring to line 431, not 430).

As for the two messages, this is what we would show, right?

"The administrator of this machine requires FOO to be installed. It cannot be
removed or modified."
"The administrator of this machine requires FOO to have a minimum version of
BAR. It cannot be enabled until it has updated to that version (or higher)."

I think there's a lot of redundancy there and you could hide the first message
and change the second message to say:

"The administrator of this machine requires FOO to have a minimum version of
BAR. It will remain disabled until it has updated to that version (or higher)."

That basically covers the gist of the other two messages (admin required + can't
be modified by user + min version).

[binjin, 2014/11/19 17:21:42]

Oops. Fixed.
Done.

+      // as well.
+      if (extension.updateRequiredByPolicy) {
+        node.querySelector('.update-required-message').hidden = false;
+      }
+
       if (extension.dependentExtensions.length > 0) {
         var dependentMessage =
             node.querySelector('.dependent-extensions-message');