Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: chrome/browser/extensions/extension_management.cc

Issue 706623004: Add minimum version to extension management (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ext-update-url
Patch Set: WIP Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_management.h" 5 #include "chrome/browser/extensions/extension_management.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/prefs/pref_service.h" 12 #include "base/prefs/pref_service.h"
13 #include "base/strings/string16.h" 13 #include "base/strings/string16.h"
14 #include "base/strings/string_util.h" 14 #include "base/strings/string_util.h"
15 #include "base/version.h"
15 #include "chrome/browser/extensions/extension_management_constants.h" 16 #include "chrome/browser/extensions/extension_management_constants.h"
16 #include "chrome/browser/extensions/extension_management_internal.h" 17 #include "chrome/browser/extensions/extension_management_internal.h"
17 #include "chrome/browser/extensions/external_policy_loader.h" 18 #include "chrome/browser/extensions/external_policy_loader.h"
18 #include "chrome/browser/extensions/external_provider_impl.h" 19 #include "chrome/browser/extensions/external_provider_impl.h"
19 #include "chrome/browser/extensions/permissions_based_management_policy_provider .h" 20 #include "chrome/browser/extensions/permissions_based_management_policy_provider .h"
20 #include "chrome/browser/extensions/standard_management_policy_provider.h" 21 #include "chrome/browser/extensions/standard_management_policy_provider.h"
21 #include "chrome/browser/profiles/incognito_helpers.h" 22 #include "chrome/browser/profiles/incognito_helpers.h"
22 #include "chrome/browser/profiles/profile.h" 23 #include "chrome/browser/profiles/profile.h"
23 #include "components/crx_file/id_util.h" 24 #include "components/crx_file/id_util.h"
24 #include "components/keyed_service/content/browser_context_dependency_manager.h" 25 #include "components/keyed_service/content/browser_context_dependency_manager.h"
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 bool ExtensionManagement::IsPermissionSetAllowed( 211 bool ExtensionManagement::IsPermissionSetAllowed(
211 const Extension* extension, 212 const Extension* extension,
212 scoped_refptr<const PermissionSet> perms) const { 213 scoped_refptr<const PermissionSet> perms) const {
213 for (const auto& blocked_api : GetBlockedAPIPermissions(extension)) { 214 for (const auto& blocked_api : GetBlockedAPIPermissions(extension)) {
214 if (perms->HasAPIPermission(blocked_api->id())) 215 if (perms->HasAPIPermission(blocked_api->id()))
215 return false; 216 return false;
216 } 217 }
217 return true; 218 return true;
218 } 219 }
219 220
221 bool ExtensionManagement::CheckMinimumVersion(
222 const Extension* extension,
223 std::string* required_version) const {
224 auto iter = settings_by_id_.find(extension->id());
225 // If there are no minimum version required for |extension|, return true.
226 if (iter == settings_by_id_.end() || !iter->second->minimum_version)
227 return true;
228 bool met_requirement =
229 extension->version()->CompareTo(*iter->second->minimum_version) >= 0;
230 // Output a human readable version string for prompting if necessary.
231 if (!met_requirement && required_version)
232 *required_version = iter->second->minimum_version->GetString();
233 return met_requirement;
234 }
235
220 void ExtensionManagement::Refresh() { 236 void ExtensionManagement::Refresh() {
221 // Load all extension management settings preferences. 237 // Load all extension management settings preferences.
222 const base::ListValue* allowed_list_pref = 238 const base::ListValue* allowed_list_pref =
223 static_cast<const base::ListValue*>(LoadPreference( 239 static_cast<const base::ListValue*>(LoadPreference(
224 pref_names::kInstallAllowList, true, base::Value::TYPE_LIST)); 240 pref_names::kInstallAllowList, true, base::Value::TYPE_LIST));
225 // Allow user to use preference to block certain extensions. Note that policy 241 // Allow user to use preference to block certain extensions. Note that policy
226 // managed forcelist or whitelist will always override this. 242 // managed forcelist or whitelist will always override this.
227 const base::ListValue* denied_list_pref = 243 const base::ListValue* denied_list_pref =
228 static_cast<const base::ListValue*>(LoadPreference( 244 static_cast<const base::ListValue*>(LoadPreference(
229 pref_names::kInstallDenyList, false, base::Value::TYPE_LIST)); 245 pref_names::kInstallDenyList, false, base::Value::TYPE_LIST));
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 FOR_EACH_OBSERVER( 428 FOR_EACH_OBSERVER(
413 Observer, observer_list_, OnExtensionManagementSettingsChanged()); 429 Observer, observer_list_, OnExtensionManagementSettingsChanged());
414 } 430 }
415 431
416 internal::IndividualSettings* ExtensionManagement::AccessById( 432 internal::IndividualSettings* ExtensionManagement::AccessById(
417 const ExtensionId& id) { 433 const ExtensionId& id) {
418 DCHECK(crx_file::id_util::IdIsValid(id)) << "Invalid ID: " << id; 434 DCHECK(crx_file::id_util::IdIsValid(id)) << "Invalid ID: " << id;
419 SettingsIdMap::iterator it = settings_by_id_.find(id); 435 SettingsIdMap::iterator it = settings_by_id_.find(id);
420 if (it == settings_by_id_.end()) { 436 if (it == settings_by_id_.end()) {
421 scoped_ptr<internal::IndividualSettings> settings( 437 scoped_ptr<internal::IndividualSettings> settings(
422 new internal::IndividualSettings(*default_settings_)); 438 new internal::IndividualSettings(default_settings_.get()));
423 it = settings_by_id_.add(id, settings.Pass()).first; 439 it = settings_by_id_.add(id, settings.Pass()).first;
424 } 440 }
425 return it->second; 441 return it->second;
426 } 442 }
427 443
428 internal::IndividualSettings* ExtensionManagement::AccessByUpdateUrl( 444 internal::IndividualSettings* ExtensionManagement::AccessByUpdateUrl(
429 const std::string& update_url) { 445 const std::string& update_url) {
430 DCHECK(GURL(update_url).is_valid()) << "Invalid update URL: " << update_url; 446 DCHECK(GURL(update_url).is_valid()) << "Invalid update URL: " << update_url;
431 SettingsUpdateUrlMap::iterator it = settings_by_update_url_.find(update_url); 447 SettingsUpdateUrlMap::iterator it = settings_by_update_url_.find(update_url);
432 if (it == settings_by_update_url_.end()) { 448 if (it == settings_by_update_url_.end()) {
433 scoped_ptr<internal::IndividualSettings> settings( 449 scoped_ptr<internal::IndividualSettings> settings(
434 new internal::IndividualSettings(*default_settings_)); 450 new internal::IndividualSettings(default_settings_.get()));
435 it = settings_by_update_url_.add(update_url, settings.Pass()).first; 451 it = settings_by_update_url_.add(update_url, settings.Pass()).first;
436 } 452 }
437 return it->second; 453 return it->second;
438 } 454 }
439 455
440 ExtensionManagement* ExtensionManagementFactory::GetForBrowserContext( 456 ExtensionManagement* ExtensionManagementFactory::GetForBrowserContext(
441 content::BrowserContext* context) { 457 content::BrowserContext* context) {
442 return static_cast<ExtensionManagement*>( 458 return static_cast<ExtensionManagement*>(
443 GetInstance()->GetServiceForBrowserContext(context, true)); 459 GetInstance()->GetServiceForBrowserContext(context, true));
444 } 460 }
(...skipping 23 matching lines...) Expand all
468 } 484 }
469 485
470 void ExtensionManagementFactory::RegisterProfilePrefs( 486 void ExtensionManagementFactory::RegisterProfilePrefs(
471 user_prefs::PrefRegistrySyncable* user_prefs) { 487 user_prefs::PrefRegistrySyncable* user_prefs) {
472 user_prefs->RegisterDictionaryPref( 488 user_prefs->RegisterDictionaryPref(
473 pref_names::kExtensionManagement, 489 pref_names::kExtensionManagement,
474 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 490 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
475 } 491 }
476 492
477 } // namespace extensions 493 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698