Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 706623004: Add minimum version to extension management (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ext-update-url
Patch Set: fixes addressing #39 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h" 5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
6 6
7 #include "apps/app_load_service.h" 7 #include "apps/app_load_service.h"
8 #include "apps/saved_files_service.h" 8 #include "apps/saved_files_service.h"
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "base/base64.h" 10 #include "base/base64.h"
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 bool suspicious_install = 251 bool suspicious_install =
252 (disable_reasons & Extension::DISABLE_NOT_VERIFIED) != 0; 252 (disable_reasons & Extension::DISABLE_NOT_VERIFIED) != 0;
253 extension_data->SetBoolean("suspiciousInstall", suspicious_install); 253 extension_data->SetBoolean("suspiciousInstall", suspicious_install);
254 if (suspicious_install) 254 if (suspicious_install)
255 should_do_verification_check_ = true; 255 should_do_verification_check_ = true;
256 256
257 bool corrupt_install = 257 bool corrupt_install =
258 (disable_reasons & Extension::DISABLE_CORRUPTED) != 0; 258 (disable_reasons & Extension::DISABLE_CORRUPTED) != 0;
259 extension_data->SetBoolean("corruptInstall", corrupt_install); 259 extension_data->SetBoolean("corruptInstall", corrupt_install);
260 260
261 bool update_required_by_policy =
262 (disable_reasons & Extension::DISABLE_UPDATE_REQUIRED_BY_POLICY) != 0;
263 extension_data->SetBoolean("updateRequiredByPolicy",
264 update_required_by_policy);
265
261 bool managed_install = 266 bool managed_install =
262 !management_policy_->UserMayModifySettings(extension, NULL); 267 !management_policy_->UserMayModifySettings(extension, NULL);
263 extension_data->SetBoolean("managedInstall", managed_install); 268 extension_data->SetBoolean("managedInstall", managed_install);
264 269
265 bool recommended_install = 270 bool recommended_install =
266 !managed_install && 271 !managed_install &&
267 management_policy_->MustRemainInstalled(extension, NULL); 272 management_policy_->MustRemainInstalled(extension, NULL);
268 extension_data->SetBoolean("recommendedInstall", recommended_install); 273 extension_data->SetBoolean("recommendedInstall", recommended_install);
269 274
270 // Suspicious install should always be mutually exclusive to managed and/or 275 // Suspicious install should always be mutually exclusive to managed and/or
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 source->AddString("extensionSettingsCrashMessage", 624 source->AddString("extensionSettingsCrashMessage",
620 l10n_util::GetStringUTF16(IDS_EXTENSIONS_CRASHED_EXTENSION)); 625 l10n_util::GetStringUTF16(IDS_EXTENSIONS_CRASHED_EXTENSION));
621 source->AddString("extensionSettingsInDevelopment", 626 source->AddString("extensionSettingsInDevelopment",
622 l10n_util::GetStringUTF16(IDS_EXTENSIONS_IN_DEVELOPMENT)); 627 l10n_util::GetStringUTF16(IDS_EXTENSIONS_IN_DEVELOPMENT));
623 source->AddString("extensionSettingsWarningsTitle", 628 source->AddString("extensionSettingsWarningsTitle",
624 l10n_util::GetStringUTF16(IDS_EXTENSION_WARNINGS_TITLE)); 629 l10n_util::GetStringUTF16(IDS_EXTENSION_WARNINGS_TITLE));
625 source->AddString("extensionSettingsShowDetails", 630 source->AddString("extensionSettingsShowDetails",
626 l10n_util::GetStringUTF16(IDS_EXTENSIONS_SHOW_DETAILS)); 631 l10n_util::GetStringUTF16(IDS_EXTENSIONS_SHOW_DETAILS));
627 source->AddString("extensionSettingsHideDetails", 632 source->AddString("extensionSettingsHideDetails",
628 l10n_util::GetStringUTF16(IDS_EXTENSIONS_HIDE_DETAILS)); 633 l10n_util::GetStringUTF16(IDS_EXTENSIONS_HIDE_DETAILS));
634 source->AddString("extensionSettingsUpdateRequiredBePolicy",
635 l10n_util::GetStringUTF16(
636 IDS_EXTENSIONS_DISABLED_UPDATE_REQUIRED_BY_POLICY));
629 637
630 // TODO(estade): comb through the above strings to find ones no longer used in 638 // TODO(estade): comb through the above strings to find ones no longer used in
631 // uber extensions. 639 // uber extensions.
632 source->AddString("extensionUninstall", 640 source->AddString("extensionUninstall",
633 l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNINSTALL)); 641 l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNINSTALL));
634 } 642 }
635 643
636 void ExtensionSettingsHandler::RenderViewDeleted( 644 void ExtensionSettingsHandler::RenderViewDeleted(
637 RenderViewHost* render_view_host) { 645 RenderViewHost* render_view_host) {
638 deleting_rvh_ = render_view_host; 646 deleting_rvh_ = render_view_host;
(...skipping 877 matching lines...) Expand 10 before | Expand all | Expand 10 after
1516 extension_service_->EnableExtension(extension_id); 1524 extension_service_->EnableExtension(extension_id);
1517 } else { 1525 } else {
1518 ExtensionErrorReporter::GetInstance()->ReportError( 1526 ExtensionErrorReporter::GetInstance()->ReportError(
1519 base::UTF8ToUTF16(JoinString(requirement_errors, ' ')), 1527 base::UTF8ToUTF16(JoinString(requirement_errors, ' ')),
1520 true); // Be noisy. 1528 true); // Be noisy.
1521 } 1529 }
1522 requirements_checker_.reset(); 1530 requirements_checker_.reset();
1523 } 1531 }
1524 1532
1525 } // namespace extensions 1533 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698