Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 706623003: Revert of Prevent inherited style from propagating into a plugin placeholder. (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
esprehn, Mike West, jbroman
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, Mike West
Project:
blink
Visibility:
Public.

Description

Revert of Prevent inherited style from propagating into a plugin placeholder. (patchset #3 id:40001 of https://codereview.chromium.org/669883003/) Reason for revert: Causing layout test fast/plugins/plugin-placeholder-inherit.html to fail. Original issue's description: > Prevent inherited style from propagating into a plugin placeholder. > > Without setting 'all: initial', it's possible for text colours and such to be > inherited by the placeholder, which is unexpected. > > TEST=fast/plugins/plugin-placeholder-inherit.html > BUG=364716 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184878 TBR=esprehn@chromium.org,mkwst@chromium.org,jbroman@chromium.org NOTREECHECKS=true NOTRY=true BUG=364716 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M LayoutTests/fast/plugins/plugin-placeholder.css View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-inherit.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/plugins/plugin-placeholder-inherit-expected.html View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/html/shadow/PluginPlaceholderElement.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dcheng
Created Revert of Prevent inherited style from propagating into a plugin placeholder.
6 years, 1 month ago (2014-11-05 19:21:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706623003/1
6 years, 1 month ago (2014-11-05 19:22:45 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 19:23:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184880

Powered by Google App Engine
This is Rietveld 408576698