Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Issue 706573003: [WebSocket] Remove layout tests about deflate-frame extension (Closed)

Created:
6 years, 1 month ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 1 month ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[WebSocket] Remove layout tests about deflate-frame extension The new WebSocket implementation doesn't support the extension. R=yhirano BUG=339373 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184871

Patch Set 1 #

Patch Set 2 : Addressed #5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -589 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/websocket/deflate-frame-comp-bit-onoff.html View 1 chunk +0 lines, -57 lines 0 comments Download
D LayoutTests/http/tests/websocket/deflate-frame-comp-bit-onoff-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/http/tests/websocket/deflate-frame-invalid-parameter.html View 1 chunk +0 lines, -54 lines 0 comments Download
D LayoutTests/http/tests/websocket/deflate-frame-invalid-parameter-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/http/tests/websocket/deflate-frame-invalid-parameter_wsh.py View 1 chunk +0 lines, -57 lines 0 comments Download
D LayoutTests/http/tests/websocket/deflate-frame-parameter.html View 1 chunk +0 lines, -87 lines 0 comments Download
D LayoutTests/http/tests/websocket/deflate-frame-parameter-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/http/tests/websocket/deflate-frame-set-bfinal.html View 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/http/tests/websocket/deflate-frame-set-bfinal-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/http/tests/websocket/deflate-frame_wsh.py View 1 1 chunk +0 lines, -87 lines 0 comments Download
D LayoutTests/http/tests/websocket/handshake-fail-by-no-cr.html View 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/http/tests/websocket/handshake-fail-by-no-cr-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/http/tests/websocket/handshake-fail-by-no-cr_wsh.py View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
tyoshino (SeeGerritForStatus)
6 years, 1 month ago (2014-11-05 11:31:12 UTC) #2
yhirano
Why did you delete handshake-fail-by-no-cr?
6 years, 1 month ago (2014-11-05 11:36:01 UTC) #3
tyoshino (SeeGerritForStatus)
On 2014/11/05 11:36:01, yhirano wrote: > Why did you delete handshake-fail-by-no-cr? IIRC, the new stack ...
6 years, 1 month ago (2014-11-05 11:40:27 UTC) #4
yhirano
On 2014/11/05 11:40:27, tyoshino wrote: > On 2014/11/05 11:36:01, yhirano wrote: > > Why did ...
6 years, 1 month ago (2014-11-05 11:44:06 UTC) #5
tyoshino (SeeGerritForStatus)
On 2014/11/05 11:44:06, yhirano wrote: > On 2014/11/05 11:40:27, tyoshino wrote: > > On 2014/11/05 ...
6 years, 1 month ago (2014-11-05 12:03:26 UTC) #6
yhirano
lgtm
6 years, 1 month ago (2014-11-05 12:42:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706573003/20001
6 years, 1 month ago (2014-11-05 12:45:29 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 13:48:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184871

Powered by Google App Engine
This is Rietveld 408576698