Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 706543002: [ServiceWorker] Stop using FetchRequestData::Mode and FetchRequestData::Credentials. (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
Reviewers:
nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Stop using FetchRequestData::Mode and FetchRequestData::Credentials. They are duplication of WebURLRequest::FetchRequestMode and WebURLRequest::FetchCredentialsMode. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184873

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -58 lines) Patch
M Source/modules/serviceworkers/FetchManager.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/serviceworkers/FetchRequestData.h View 4 chunks +7 lines, -8 lines 0 comments Download
M Source/modules/serviceworkers/FetchRequestData.cpp View 2 chunks +4 lines, -26 lines 0 comments Download
M Source/modules/serviceworkers/Request.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/Request.cpp View 7 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
horo
nhiroki@ Could you please review?
6 years, 1 month ago (2014-11-05 10:42:48 UTC) #3
nhiroki
lgtm
6 years, 1 month ago (2014-11-05 10:49:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706543002/20001
6 years, 1 month ago (2014-11-05 13:26:10 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 14:42:56 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as 184873

Powered by Google App Engine
This is Rietveld 408576698