Retry: Parser & internalization fix: ensure no heap allocs during GetString(Handle<String>).

Retry: Parser & internalization fix: ensure no heap allocs during GetString(Handle<String>).

The bug has always been there: when the parser is operating in the "immediately
internalize" mode and calls GetString, we get FlatContent of a string and then
do heap allocation.

The bug was uncovered by https://codereview.chromium.org/693803004/ (which put
the parser to the "immediately internalize" mode more often), but looking at the
code, it's possible that it can happen in other cases too.

This CL makes AstValueFactory handle this situation gracefully: it won't try to
internalize inside GetString(Handle<String>); it's unnecessary anyway since we
have the Handle<String> already.

BUG=
R=rossberg@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=25179

[marja, 2014-11-05 15:03:42]

Patchset #2 (id:2) has been deleted

[marja, 2014-11-05 15:08:36]

marja@chromium.org changed reviewers:
+ rossberg@chromium.org

[marja, 2014-11-05 15:08:37]

rossberg, ptal at this fixed fix.

The failing test was WebPageNewSerializeTest.BlankFrames and it passes with the
fix.

The failure was:


#
# Fatal error in ../../v8/src/scopeinfo.cc, line 300
# CHECK(name->IsInternalizedString()) failed
#


First patch set is the original CL and second is the fixed version.

[rossberg, 2014-11-05 15:13:34]

lgtm

[marja, 2014-11-06 08:28:51]

Committed patchset #3 (id:50001) manually as 25179 (presubmit successful).