Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: net/socket/ssl_host_info.cc

Issue 7065045: Fix nits related to SSLHostInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_host_info.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_host_info.cc
===================================================================
--- net/socket/ssl_host_info.cc (revision 86506)
+++ net/socket/ssl_host_info.cc (working copy)
@@ -94,16 +94,20 @@
state->certs.push_back(der_cert);
}
+ // Ignore obsolete members of the State structure.
std::string throwaway_string;
bool throwaway_bool;
+ // This was state->server_hello.
if (!p.ReadString(&iter, &throwaway_string))
return false;
+ // This was state->npn_valid.
if (!p.ReadBool(&iter, &throwaway_bool))
return false;
if (throwaway_bool) {
int throwaway_int;
+ // These were state->npn_status and state->npn_protocol.
if (!p.ReadInt(&iter, &throwaway_int) ||
!p.ReadString(&iter, &throwaway_string)) {
return false;
@@ -161,6 +165,8 @@
return "";
}
+ // Write dummy values for obsolete members of the State structure:
+ // state->server_hello and state->npn_valid.
if (!p.WriteString("") ||
!p.WriteBool(false)) {
return "";
« no previous file with comments | « net/socket/ssl_host_info.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698