Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Issue 706503002: Add UseCounters for lang and xml:lang content attributes. (Closed)

Created:
6 years, 1 month ago by tkent
Modified:
6 years, 1 month ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Project:
blink
Visibility:
Public.

Description

Add UseCounters for lang and xml:lang content attributes. We'd like to investigation how many pages will be affected by the feature [1]. This CL also adds counters for <input type=submit>, which is a typical affected element. [1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QpEoCwU0Ttg BUG=141169 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184882

Patch Set 1 #

Patch Set 2 : Count <input type=submit> with/without value= #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M Source/core/frame/UseCounter.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 3 chunks +23 lines, -0 lines 0 comments Download
M Source/core/html/forms/BaseButtonInputType.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/SubmitInputType.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/SubmitInputType.cpp View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, would you review this please?
6 years, 1 month ago (2014-11-05 02:54:23 UTC) #2
keishi
lgtm
6 years, 1 month ago (2014-11-05 20:24:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706503002/20001
6 years, 1 month ago (2014-11-05 21:14:42 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 21:16:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184882

Powered by Google App Engine
This is Rietveld 408576698