Automated the definitions of webview attributes as properties on the webview node.

extensions/renderer/resources/guest_view/web_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This module implements WebView (<webview>) as a custom element that wraps a
 // BrowserPlugin object element. The object element is hidden within
 // the shadow DOM of the WebView element.
 
 var DocumentNatives = requireNative('document_natives');
 var GuestViewInternal =
@@ skipping 107 matching lines @@
   }.bind(this));
 };
 
 // Validation helper function for executeScript() and insertCSS().
 WebView.prototype.validateExecuteCodeCall  = function() {
   if (!this.guestInstanceId) {
     throw new Error(WebViewConstants.ERROR_MSG_CANNOT_INJECT_SCRIPT);
   }
 };
 
-WebView.prototype.setupAutoSizeProperties = function() {
-  $Array.forEach(AUTO_SIZE_ATTRIBUTES, function(attributeName) {
-    Object.defineProperty(this.webviewNode, attributeName, {
-      get: function() {
-        return this.attributes[attributeName].getValue();
-      }.bind(this),
-      set: function(value) {
-        this.attributes[attributeName].setValue(value);
-      }.bind(this),
-      enumerable: true
-    });
-  }.bind(this), this);
-};
-
 WebView.prototype.setupWebviewNodeProperties = function() {
-  this.setupAutoSizeProperties();
-
-  Object.defineProperty(this.webviewNode,
-                        WebViewConstants.ATTRIBUTE_ALLOWTRANSPARENCY, {
-    get: function() {
-      return this.attributes[WebViewConstants.ATTRIBUTE_ALLOWTRANSPARENCY].
-          getValue();
-    }.bind(this),
-    set: function(value) {
-      this.attributes[WebViewConstants.ATTRIBUTE_ALLOWTRANSPARENCY].
-          setValue(value);
-    }.bind(this),
-    enumerable: true
-  });
+  for (var attributeName in this.attributes) {
+    this.attributes[attributeName].define();
+  }
 
   // We cannot use {writable: true} property descriptor because we want a
   // dynamic getter value.
   Object.defineProperty(this.webviewNode, 'contentWindow', {
     get: function() {
       if (this.contentWindow) {
         return this.contentWindow;
       }
       window.console.error(
           WebViewConstants.ERROR_MSG_CONTENTWINDOW_NOT_AVAILABLE);
     }.bind(this),
     // No setter.
     enumerable: true
   });
-
-  Object.defineProperty(this.webviewNode, WebViewConstants.ATTRIBUTE_NAME, {
-    get: function() {
-      return this.attributes[WebViewConstants.ATTRIBUTE_NAME].getValue();
-    }.bind(this),
-    set: function(value) {
-      this.attributes[WebViewConstants.ATTRIBUTE_NAME].setValue(value);
-    }.bind(this),
-    enumerable: true
-  });
-
-  Object.defineProperty(this.webviewNode,
-                        WebViewConstants.ATTRIBUTE_PARTITION, {
-    get: function() {
-      return this.attributes[WebViewConstants.ATTRIBUTE_PARTITION].getValue();
-    }.bind(this),
-    set: function(value) {
-      this.attributes[WebViewConstants.ATTRIBUTE_PARTITION].setValue(value);
-    }.bind(this),
-    enumerable: true
-  });
-
-  Object.defineProperty(this.webviewNode, WebViewConstants.ATTRIBUTE_SRC, {
-    get: function() {
-      return this.attributes[WebViewConstants.ATTRIBUTE_SRC].getValue();
-    }.bind(this),
-    set: function(value) {
-      this.attributes[WebViewConstants.ATTRIBUTE_SRC].setValue(value);
-    }.bind(this),
-    enumerable: true
-  });
 };
 
 // The purpose of this mutation observer is to catch assignment to the src
 // attribute without any changes to its value. This is useful in the case
 // where the webview guest has crashed and navigating to the same address
 // spawns off a new process.
 WebView.prototype.setupWebViewSrcAttributeMutationObserver =
     function() {
   this.srcAndPartitionObserver = new MutationObserver(function(mutations) {
     $Array.forEach(mutations, function(mutation) {
@@ skipping 655 matching lines @@
 WebView.prototype.maybeGetChromeWebViewEvents = function() {};
 
 // Implemented when the experimental WebView API is available.
 WebView.maybeGetExperimentalAPIs = function() {};
 WebView.prototype.maybeGetExperimentalEvents = function() {};
 WebView.prototype.setupExperimentalContextMenus = function() {};
 
 // Exports.
 exports.WebView = WebView;
 exports.WebViewInternal = WebViewInternal;