Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 706363002: SkDrawCommand scrubbing (Closed)

Created:
6 years, 1 month ago by f(malita)
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkDrawCommand scrubbing Remove unused ctor, constify, etc. R=robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/1931ec5b5dac68f1e452af0c65161bdce35b2dec

Patch Set 1 #

Total comments: 2

Patch Set 2 : getType -> const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -101 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M debugger/SkDebugger.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 1 42 chunks +50 lines, -52 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 38 chunks +39 lines, -44 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
f(malita)
Inflight hacking.
6 years, 1 month ago (2014-11-07 19:38:36 UTC) #1
robertphillips
lgtm + suggestion https://codereview.chromium.org/706363002/diff/1/src/utils/debugger/SkDrawCommand.h File src/utils/debugger/SkDrawCommand.h (right): https://codereview.chromium.org/706363002/diff/1/src/utils/debugger/SkDrawCommand.h#newcode70 src/utils/debugger/SkDrawCommand.h:70: const here too ?
6 years, 1 month ago (2014-11-07 19:47:34 UTC) #2
f(malita)
https://codereview.chromium.org/706363002/diff/1/src/utils/debugger/SkDrawCommand.h File src/utils/debugger/SkDrawCommand.h (right): https://codereview.chromium.org/706363002/diff/1/src/utils/debugger/SkDrawCommand.h#newcode70 src/utils/debugger/SkDrawCommand.h:70: On 2014/11/07 19:47:34, robertphillips wrote: > const here too ...
6 years, 1 month ago (2014-11-07 20:00:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706363002/20001
6 years, 1 month ago (2014-11-07 20:01:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/1931ec5b5dac68f1e452af0c65161bdce35b2dec
6 years, 1 month ago (2014-11-07 20:09:23 UTC) #6
f(malita)
6 years, 1 month ago (2014-11-07 20:25:44 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/712683002/ by fmalita@chromium.org.

The reason for reverting is: Canary borkage..

Powered by Google App Engine
This is Rietveld 408576698