/OAuthLogin requests should use ChannelID.

/OAuthLogin requests should use ChannelID.

R=mattm@chromium.org
BUG=315301
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235076

[mattm, 2013-11-13 03:25:09]

Seems good to me, but I don't know this code, so I'll wait for zel to review.

[zel, 2013-11-13 23:35:59]

LGTM for the code

Xiyuan@ can you please verify that this isn't messing up our /MergeSession
business.

[xiyuan, 2013-11-14 00:03:59]

On 2013/11/13 23:35:59, zel wrote:
> LGTM for the code
> 
> Xiyuan@ can you please verify that this isn't messing up our /MergeSession
> business.

First sign-in and secondary offline sign-ins with /MergeSession work correctly.

[thaidn_google, 2013-11-14 00:20:55]

Thanks! Could you please commit it for me? I don't have commit right.


On Wed, Nov 13, 2013 at 4:04 PM, <xiyuan@chromium.org> wrote:

> On 2013/11/13 23:35:59, zel wrote:
>
>> LGTM for the code
>>
>
>  Xiyuan@ can you please verify that this isn't messing up our
>> /MergeSession
>> business.
>>
>
> First sign-in and secondary offline sign-ins with /MergeSession work
> correctly.
>
> https://codereview.chromium.org/70633004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-11-14 00:27:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thaidn@google.com/70633004/90001

[commit-bot: I haz the power, 2013-11-14 01:47:26]

Retried try job too often on mac for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2013-11-14 01:59:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thaidn@google.com/70633004/90001

[commit-bot: I haz the power, 2013-11-14 02:57:21]

Retried try job too often on mac for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2013-11-14 03:43:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thaidn@google.com/70633004/90001

[commit-bot: I haz the power, 2013-11-14 06:56:00]

Change committed as 235076