Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: Source/devtools/front_end/components/FlameChart.js

Issue 706313002: DevTools: draw load/first paint marks as tall vertical delimiters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/profiler/CPUProfileFlameChart.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/components/FlameChart.js
diff --git a/Source/devtools/front_end/components/FlameChart.js b/Source/devtools/front_end/components/FlameChart.js
index 42637d929c50adde4bc15073d3f64c945ea50812..b90952a97cefe05933c975d3779304da0be7c624 100644
--- a/Source/devtools/front_end/components/FlameChart.js
+++ b/Source/devtools/front_end/components/FlameChart.js
@@ -156,6 +156,12 @@ WebInspector.FlameChartDataProvider.prototype = {
markerTitle: function(index) { },
/**
+ * @param {number} index
+ * @return {boolean}
+ */
+ isTallMarker: function(index) { },
+
+ /**
* @return {number}
*/
minimumBoundary: function() { },
@@ -1038,6 +1044,17 @@ WebInspector.FlameChart.prototype = {
context.moveTo(position, 0);
context.lineTo(position, height);
context.stroke();
+ if (this._dataProvider.isTallMarker(i)) {
+ context.save()
+ context.lineWidth = 0.5;
+ context.translate(0.5, 0.5);
+ context.beginPath();
+ context.moveTo(position, height);
+ context.setLineDash([10, 5]);
+ context.lineTo(position, this._canvas.height);
+ context.stroke();
+ context.restore();
+ }
}
context.restore();
},
« no previous file with comments | « no previous file | Source/devtools/front_end/profiler/CPUProfileFlameChart.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698