Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

Issue 706313002: DevTools: draw load/first paint marks as tall vertical delimiters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.TimelineUIUtils} 7 * @extends {WebInspector.TimelineUIUtils}
8 */ 8 */
9 WebInspector.TracingTimelineUIUtils = function() 9 WebInspector.TracingTimelineUIUtils = function()
10 { 10 {
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 case recordTypes.MarkDOMContent: 334 case recordTypes.MarkDOMContent:
335 case recordTypes.MarkLoad: 335 case recordTypes.MarkLoad:
336 return event.args["data"]["isMainFrame"]; 336 return event.args["data"]["isMainFrame"];
337 default: 337 default:
338 return false; 338 return false;
339 } 339 }
340 } 340 }
341 341
342 /** 342 /**
343 * @param {!WebInspector.TracingModel.Event} event 343 * @param {!WebInspector.TracingModel.Event} event
344 * @return {boolean}
345 */
346 WebInspector.TracingTimelineUIUtils.isTallMarkerEvent = function(event)
347 {
348 var recordTypes = WebInspector.TracingTimelineModel.RecordType;
349 switch (event.name) {
caseq 2014/11/07 17:39:40 return event.name !== recordTypes.TimeStamp for cl
yurys 2014/11/07 19:55:40 Done.
350 case recordTypes.MarkFirstPaint:
351 return true;
352 case recordTypes.MarkDOMContent:
353 case recordTypes.MarkLoad:
354 return event.args["data"]["isMainFrame"];
355 default:
356 return false;
357 }
358 }
359
360 /**
361 * @param {!WebInspector.TracingModel.Event} event
344 * @param {!WebInspector.Linkifier} linkifier 362 * @param {!WebInspector.Linkifier} linkifier
345 * @return {?Node} 363 * @return {?Node}
346 */ 364 */
347 WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent = function(eve nt, linkifier) 365 WebInspector.TracingTimelineUIUtils.buildDetailsNodeForTraceEvent = function(eve nt, linkifier)
348 { 366 {
349 var recordType = WebInspector.TracingTimelineModel.RecordType; 367 var recordType = WebInspector.TracingTimelineModel.RecordType;
350 var target = event.thread.target(); 368 var target = event.thread.target();
351 var details; 369 var details;
352 var detailsText; 370 var detailsText;
353 var eventData = event.args["data"]; 371 var eventData = event.args["data"];
(...skipping 626 matching lines...) Expand 10 before | Expand all | Expand 10 after
980 return result; 998 return result;
981 } 999 }
982 1000
983 /** 1001 /**
984 * @return {!WebInspector.TracingTimelineModel.Filter} 1002 * @return {!WebInspector.TracingTimelineModel.Filter}
985 */ 1003 */
986 WebInspector.TracingTimelineUIUtils.hiddenEventsFilter = function() 1004 WebInspector.TracingTimelineUIUtils.hiddenEventsFilter = function()
987 { 1005 {
988 return new WebInspector.TracingTimelineModel.InclusiveEventNameFilter(WebIns pector.TracingTimelineUIUtils._visibleTypes()); 1006 return new WebInspector.TracingTimelineModel.InclusiveEventNameFilter(WebIns pector.TracingTimelineUIUtils._visibleTypes());
989 } 1007 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698