DevTools: draw load/first paint marks as tall vertical delimiters

Source/devtools/front_end/components/FlameChart.js

 /**
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 138 matching lines @@
      */
     markerColor: function(index) { },
 
     /**
      * @param {number} index
      * @return {string}
      */
     markerTitle: function(index) { },
 
     /**
+     * @param {number} index
+     * @return {boolean}
+     */
+    isTallMarker: function(index) { },

[caseq, 2014/11/07 17:39:40]

nit: I wonder if we should generalize this to markerType?

[yurys, 2014/11/07 19:55:39]

I don't see other types at the moment so there is no rush and current method
looks more clear. We can always refactor this.

+
+    /**
      * @return {number}
      */
     minimumBoundary: function() { },
 
     /**
      * @return {number}
      */
     totalTime: function() { },
 
     /**
@@ skipping 862 matching lines @@
         for (var i = left; i < markerTimestamps.length; i++) {
             var timestamp = markerTimestamps[i];
             if (timestamp > rightBoundary)
                 break;
             var position = this._calculator.computePosition(timestamp);
             context.strokeStyle = this._dataProvider.markerColor(i);
             context.beginPath();
             context.moveTo(position, 0);
             context.lineTo(position, height);
             context.stroke();
+            if (this._dataProvider.isTallMarker(i)) {
+                context.save()
+                context.lineWidth = 1;

[caseq, 2014/11/07 17:39:40]

Is this supposed to have effect?

[yurys, 2014/11/07 19:55:39]

Yes, because outer context scope sets line width to 2.

[caseq, 2014/11/07 20:00:37]

You have "context.lineWidth = 0.5;" below.

[yurys, 2014/11/07 20:02:56]

Oh, I see, it should be just lineWidth = 1 and translate(0.5, 0.5). Thanks!

+                context.translate(0.5, 0.5);
+                context.beginPath();
+                context.moveTo(position, height);
+                context.lineWidth = 0.5;
+                context.setLineDash([10, 5]);
+                context.lineTo(position, this._canvas.height);
+                context.stroke();
+                context.restore();
+            }
         }
         context.restore();
     },
 
     _updateMarkerHighlight: function()
     {
         var element = this._markerHighlighElement;
         if (element.parentElement)
             element.remove();
         var markerIndex = this._highlightedMarkerIndex;
@@ skipping 216 matching lines @@
         this.update();
     },
 
     _enabled: function()
     {
         return this._rawTimelineDataLength !== 0;
     },
 
     __proto__: WebInspector.HBox.prototype
 }