Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 706273002: Add ability to query and allocate zero copy buffers. (Closed)

Created:
6 years, 1 month ago by alexst (slow to review)
Modified:
6 years, 1 month ago
Reviewers:
spang
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add ability to query and allocate zero copy buffers. BUG= Committed: https://crrev.com/7b84691293a8aa7fe298a8c7be53af4af1444e79 Cr-Commit-Position: refs/heads/master@{#303470}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -10 lines) Patch
M ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc View 1 2 chunks +14 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.cc View 1 2 chunks +18 lines, -3 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.h View 3 chunks +13 lines, -4 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
alexst (slow to review)
Adding ability to allocate zero copy via ozone in anticipation of the new world of ...
6 years, 1 month ago (2014-11-07 15:47:44 UTC) #3
spang
https://codereview.chromium.org/706273002/diff/20001/ui/ozone/public/surface_factory_ozone.h File ui/ozone/public/surface_factory_ozone.h (right): https://codereview.chromium.org/706273002/diff/20001/ui/ozone/public/surface_factory_ozone.h#newcode72 ui/ozone/public/surface_factory_ozone.h:72: MAP, do we ever want both (MAP | SCANOUT)?
6 years, 1 month ago (2014-11-07 17:42:06 UTC) #4
alexst (slow to review)
On 2014/11/07 17:42:06, spang wrote: > https://codereview.chromium.org/706273002/diff/20001/ui/ozone/public/surface_factory_ozone.h > File ui/ozone/public/surface_factory_ozone.h (right): > > https://codereview.chromium.org/706273002/diff/20001/ui/ozone/public/surface_factory_ozone.h#newcode72 > ...
6 years, 1 month ago (2014-11-07 17:44:50 UTC) #5
spang
lgtm
6 years, 1 month ago (2014-11-07 17:48:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706273002/20001
6 years, 1 month ago (2014-11-10 13:28:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/89770) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/79464) android_aosp ...
6 years, 1 month ago (2014-11-10 13:31:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706273002/40001
6 years, 1 month ago (2014-11-10 15:07:44 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 1 month ago (2014-11-10 15:52:14 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 15:53:37 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b84691293a8aa7fe298a8c7be53af4af1444e79
Cr-Commit-Position: refs/heads/master@{#303470}

Powered by Google App Engine
This is Rietveld 408576698