Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 7062044: Merge 86507 - 2011-05-15 Ilya Tikhonovsky <loislo@chromium.org> (Closed)

Created:
8 years ago by apavlov
Modified:
8 years ago
Reviewers:
loislo
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/742/
Visibility:
Public.

Description

Merge 86507 - 2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>; Reviewed by Yury Semikhatsky. Web Inspector: chromium renderer crash at eval in console. https://bugs.webkit.org/show_bug.cgi?id=60616 Renderer of inspected page is crashing when modal dialog has been opened via console eval and page is reloaded. Test: inspector/console/console-long-eval-crash.html * inspector/CodeGeneratorInspector.pm: * inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::dispatchMessageFromFrontend): * inspector/InspectorController.h: 2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>; Reviewed by Yury Semikhatsky. Web Inspector: chromium renderer crash at eval in console. https://bugs.webkit.org/show_bug.cgi?id=60616 Renderer of inspected page is crashing when modal dialog has been opened via console eval and page is reloaded. * inspector/console/console-long-eval-crash-expected.txt: Added. * inspector/console/console-long-eval-crash.html: Added. * platform/gtk/Skipped: * platform/mac-wk2/Skipped: * platform/qt-wk2/Skipped: * platform/win/Skipped: TBR=loislo@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
A + LayoutTests/inspector/console/console-long-eval-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/console/console-long-eval-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/gtk/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac-wk2/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/qt-wk2/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/inspector/CodeGeneratorInspector.pm View 12 chunks +19 lines, -6 lines 0 comments Download
M Source/WebCore/inspector/InspectorController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/inspector/InspectorController.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
apavlov
8 years ago (2011-05-27 09:27:10 UTC) #1
loislo
8 years ago (2011-05-27 09:36:26 UTC) #2
On 2011/05/27 09:27:10, apavlov wrote:
lgtm

Powered by Google App Engine
This is Rietveld 408576698