Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4018)

Unified Diff: base/android/library_loader/library_load_from_apk_status_codes.h

Issue 706203003: Update from https://crrev.com/303153 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/library_loader/library_load_from_apk_status_codes.h
diff --git a/base/android/library_loader/library_load_from_apk_status_codes.h b/base/android/library_loader/library_load_from_apk_status_codes.h
index 21f40bca282f1a2dd0e39e2f6f180dcb617220db..f99eebc89891456ac825dad953d5367fe96e2b48 100644
--- a/base/android/library_loader/library_load_from_apk_status_codes.h
+++ b/base/android/library_loader/library_load_from_apk_status_codes.h
@@ -10,6 +10,8 @@ namespace android {
namespace {
+// This enum must be kept in sync with the LibraryLoadFromApkStatus enum in
+// tools/metrics/histograms/histograms.xml.
// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.base.library_loader
enum LibraryLoadFromApkStatusCodes {
// The loader was unable to determine whether the functionality is supported.
@@ -24,11 +26,16 @@ enum LibraryLoadFromApkStatusCodes {
// The Chromium library was successfully loaded directly from the APK file.
LIBRARY_LOAD_FROM_APK_STATUS_CODES_SUCCESSFUL = 3,
- // The Chromium library was not page aligned in the APK file.
- LIBRARY_LOAD_FROM_APK_STATUS_CODES_NOT_ALIGNED = 4,
+ // The Chromium library was successfully loaded using the unpack library
+ // fallback because it was compressed or not page aligned in the APK file.
+ LIBRARY_LOAD_FROM_APK_STATUS_CODES_USED_UNPACK_LIBRARY_FALLBACK = 4,
+
+ // The Chromium library was successfully loaded using the no map executable
+ // support fallback.
+ LIBRARY_LOAD_FROM_APK_STATUS_CODES_USED_NO_MAP_EXEC_SUPPORT_FALLBACK = 5,
// End sentinel.
- LIBRARY_LOAD_FROM_APK_STATUS_CODES_MAX = 5,
+ LIBRARY_LOAD_FROM_APK_STATUS_CODES_MAX = 6,
};
} // namespace
« no previous file with comments | « base/android/java/src/org/chromium/base/library_loader/Linker.java ('k') | base/android/linker/linker_jni.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698