Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: gpu/command_buffer/service/gpu_scheduler_unittest.cc

Issue 706203003: Update from https://crrev.com/303153 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/gpu_scheduler.cc ('k') | gpu/ipc/gpu_command_buffer_traits.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gpu_scheduler_unittest.cc
diff --git a/gpu/command_buffer/service/gpu_scheduler_unittest.cc b/gpu/command_buffer/service/gpu_scheduler_unittest.cc
index d8233ecbd678ef4470e801201ae046728a978df0..c1c0d1c360949339154128337f457548fb7bf7ab 100644
--- a/gpu/command_buffer/service/gpu_scheduler_unittest.cc
+++ b/gpu/command_buffer/service/gpu_scheduler_unittest.cc
@@ -26,7 +26,6 @@ using testing::StrictMock;
namespace gpu {
const size_t kRingBufferSize = 1024;
-const size_t kRingBufferEntries = kRingBufferSize / sizeof(CommandBufferEntry);
class GpuSchedulerTest : public testing::Test {
protected:
@@ -43,9 +42,10 @@ class GpuSchedulerTest : public testing::Test {
command_buffer_.reset(new MockCommandBuffer);
CommandBuffer::State default_state;
- default_state.num_entries = kRingBufferEntries;
ON_CALL(*command_buffer_.get(), GetLastState())
.WillByDefault(Return(default_state));
+ ON_CALL(*command_buffer_.get(), GetPutOffset())
+ .WillByDefault(Return(0));
decoder_.reset(new gles2::MockGLES2Decoder());
// Install FakeDoCommands handler so we can use individual DoCommand()
@@ -86,7 +86,6 @@ class GpuSchedulerTest : public testing::Test {
TEST_F(GpuSchedulerTest, SchedulerDoesNothingIfRingBufferIsEmpty) {
CommandBuffer::State state;
- state.put_offset = 0;
EXPECT_CALL(*command_buffer_, GetLastState())
.WillRepeatedly(Return(state));
@@ -122,9 +121,10 @@ TEST_F(GpuSchedulerTest, ProcessesOneCommand) {
CommandBuffer::State state;
- state.put_offset = 2;
EXPECT_CALL(*command_buffer_, GetLastState())
.WillRepeatedly(Return(state));
+ EXPECT_CALL(*command_buffer_, GetPutOffset())
+ .WillRepeatedly(Return(2));
EXPECT_CALL(*command_buffer_, SetGetOffset(2));
EXPECT_CALL(*decoder_, DoCommand(7, 1, &buffer_[0]))
@@ -146,9 +146,10 @@ TEST_F(GpuSchedulerTest, ProcessesTwoCommands) {
CommandBuffer::State state;
- state.put_offset = 3;
EXPECT_CALL(*command_buffer_, GetLastState())
.WillRepeatedly(Return(state));
+ EXPECT_CALL(*command_buffer_, GetPutOffset())
+ .WillRepeatedly(Return(3));
EXPECT_CALL(*decoder_, DoCommand(7, 1, &buffer_[0]))
.WillOnce(Return(error::kNoError));
@@ -167,9 +168,10 @@ TEST_F(GpuSchedulerTest, SetsErrorCodeOnCommandBuffer) {
CommandBuffer::State state;
- state.put_offset = 1;
EXPECT_CALL(*command_buffer_, GetLastState())
.WillRepeatedly(Return(state));
+ EXPECT_CALL(*command_buffer_, GetPutOffset())
+ .WillRepeatedly(Return(1));
EXPECT_CALL(*decoder_, DoCommand(7, 0, &buffer_[0]))
.WillOnce(Return(
« no previous file with comments | « gpu/command_buffer/service/gpu_scheduler.cc ('k') | gpu/ipc/gpu_command_buffer_traits.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698